Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 298863011: Merge the classes Debug and Debugger. (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Merge the classes Debug and Debugger. Also: - moved code around to more appropriate locations - removed dead code - inlined where it made sense. R=ulan@chromium.org

Patch Set 1 #

Patch Set 2 : fix x64 build #

Patch Set 3 : entering the debugger should not by itself activate the debugger. #

Patch Set 4 : Rename EnterDebugger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+987 lines, -1267 lines) Patch
M src/api.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M src/arm/assembler-arm.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm/debug-arm.cc View 13 chunks +17 lines, -17 lines 0 comments Download
M src/arm64/assembler-arm64.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/arm64/debug-arm64.cc View 14 chunks +19 lines, -18 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +13 lines, -13 lines 0 comments Download
M src/compiler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/debug.h View 1 2 3 10 chunks +342 lines, -502 lines 0 comments Download
M src/debug.cc View 1 2 3 54 chunks +349 lines, -517 lines 0 comments Download
M src/execution.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/execution.cc View 3 chunks +2 lines, -56 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/debug-ia32.cc View 15 chunks +20 lines, -23 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 2 3 4 chunks +2 lines, -5 lines 0 comments Download
M src/liveedit.h View 2 chunks +58 lines, -0 lines 0 comments Download
M src/liveedit.cc View 11 chunks +81 lines, -28 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/debug-mips.cc View 13 chunks +16 lines, -17 lines 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 2 3 19 chunks +19 lines, -19 lines 0 comments Download
M src/x64/debug-x64.cc View 1 15 chunks +19 lines, -20 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Yang
6 years, 7 months ago (2014-05-23 09:54:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698