Compute the script Uri lazily

Compute the script Uri lazily

Previously, the string set up by the embedder was eagerly passed to
Uri.parse during Isolate startup. This is expensive both in time and
memory footprint. This CL causes Uri.parse() to be called only
when needed. This change will allow reducing the memory footprint
of Fuchsia's Dart content handler on hello world by ~1MB.

fixes #25603

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/9e7e66602f033c5163c8bfd27471c48d9e93945b

[zra, 2017-07-24 03:24:58]

Description was changed from

==========
Compute the script Uri lazily

Previously, the string set up by the embedder was eagerly passed to
Uri.parse during Isolate startup. This is expensive both in time and
memory footprint. This changes causes Uri.parse() to be called only
when needed. This change will allow reducing the memory footprint
of Fuchsia's Dart content handler on hello world by 1MB.

fixes #25603
==========

to

==========
Compute the script Uri lazily

Previously, the string set up by the embedder was eagerly passed to
Uri.parse during Isolate startup. This is expensive both in time and
memory footprint. This CL causes Uri.parse() to be called only
when needed. This change will allow reducing the memory footprint
of Fuchsia's Dart content handler on hello world by ~1MB.

fixes #25603
==========

[zra, 2017-07-24 14:44:01]

zra@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[siva, 2017-07-24 15:10:07]

Is this CL the first part of another change? I am not able to figure out where
the lazy call to Uri.Parse happens.

[zra, 2017-07-24 15:32:48]

https://codereview.chromium.org/2988613002/diff/1/runtime/bin/platform_patch....
File runtime/bin/platform_patch.dart (right):

https://codereview.chromium.org/2988613002/diff/1/runtime/bin/platform_patch....
runtime/bin/platform_patch.dart:39: static void set _nativeScript(String path) {
In the standalone VM, this setter is called from the embedder. In
Flutter/Fuchsia, VMLibraryHooks.platformScript is set in the builtin library's
_setupHooks().

[siva, 2017-07-24 16:44:58]

lgtm

[zra, 2017-07-24 19:56:26]

Description was changed from

==========
Compute the script Uri lazily

Previously, the string set up by the embedder was eagerly passed to
Uri.parse during Isolate startup. This is expensive both in time and
memory footprint. This CL causes Uri.parse() to be called only
when needed. This change will allow reducing the memory footprint
of Fuchsia's Dart content handler on hello world by ~1MB.

fixes #25603
==========

to

==========
Compute the script Uri lazily

Previously, the string set up by the embedder was eagerly passed to
Uri.parse during Isolate startup. This is expensive both in time and
memory footprint. This CL causes Uri.parse() to be called only
when needed. This change will allow reducing the memory footprint
of Fuchsia's Dart content handler on hello world by ~1MB.

fixes #25603

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9e7e66602f033c5163c8bfd27471c48d9e93945b
==========

[zra, 2017-07-24 19:56:28]

Committed patchset #1 (id:1) manually as
9e7e66602f033c5163c8bfd27471c48d9e93945b (presubmit successful).