Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2988573002: Migrate block 6 to Dart 2.0. (Closed)

Created:
3 years, 5 months ago by jcollins
Modified:
3 years, 5 months ago
Reviewers:
bkonyi, *Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate test block 6 to Dart 2.0. Unusual things in this block: - This is my first attempt to fix a multitest with various errors in it, double_parse_test.dart. Most of them revolve around multitest #01 and the conflict it has with the new multitest #04. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/7fdc6eb1285c689da9da684b83006af70f186853

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -3466 lines) Patch
M tests/corelib/corelib.status View 2 chunks +0 lines, -9 lines 0 comments Download
D tests/corelib/double_ceil_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/corelib/double_ceil_to_double_test.dart View 1 chunk +0 lines, -93 lines 0 comments Download
D tests/corelib/double_compare_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/corelib/double_floor2_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib/double_floor_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/corelib/double_floor_to_double_test.dart View 1 chunk +0 lines, -85 lines 0 comments Download
D tests/corelib/double_parse_test.dart View 1 chunk +0 lines, -1196 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 chunk +6 lines, -0 lines 0 comments Download
A + tests/corelib_2/double_ceil_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/double_ceil_to_double_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/double_compare_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/double_floor2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/double_floor_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/double_floor_to_double_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/double_parse_test.dart View 13 chunks +277 lines, -256 lines 1 comment Download
M tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -1 line 0 comments Download
D tests/corelib_strong/double_ceil_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/corelib_strong/double_ceil_to_double_test.dart View 1 chunk +0 lines, -93 lines 0 comments Download
D tests/corelib_strong/double_compare_test.dart View 1 chunk +0 lines, -49 lines 0 comments Download
D tests/corelib_strong/double_floor2_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/corelib_strong/double_floor_test.dart View 1 chunk +0 lines, -84 lines 0 comments Download
D tests/corelib_strong/double_floor_to_double_test.dart View 1 chunk +0 lines, -85 lines 0 comments Download
D tests/corelib_strong/double_parse_test.dart View 1 chunk +0 lines, -1196 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
jcollins
This is me learning multitests, be warned.
3 years, 5 months ago (2017-07-21 21:52:48 UTC) #5
Bob Nystrom
lgtm https://codereview.chromium.org/2988573002/diff/1/tests/corelib_2/double_parse_test.dart File tests/corelib_2/double_parse_test.dart (right): https://codereview.chromium.org/2988573002/diff/1/tests/corelib_2/double_parse_test.dart#newcode1074 tests/corelib_2/double_parse_test.dart:1074: 2.0); //# 03: ok I *think* these all ...
3 years, 5 months ago (2017-07-24 22:19:48 UTC) #6
jcollins
3 years, 5 months ago (2017-07-25 15:13:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7fdc6eb1285c689da9da684b83006af70f186853.

Powered by Google App Engine
This is Rietveld 408576698