Compute closure model purely from IR nodes

Compute closure model purely from IR nodes

- and convert it to the J-model afterwards.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/6e280fc4f441d21ced2590cd3f7097c5dc22889f

[Johnni Winther, 2017-07-21 18:33:27]

johnniwinther@google.com changed reviewers:
+ efortuna@google.com

[Emily Fortuna, 2017-07-26 18:04:23]

lgtm

https://codereview.chromium.org/2988553003/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/closure.dart (right):

https://codereview.chromium.org/2988553003/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:69: // TODO(johnniwinther,efortuna):
Compute this during resolution.
see also the existing documentation on convertClosures

https://codereview.chromium.org/2988553003/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:500: /// Collection [ScopeInfo] data
for the member, if any.
please add clarification in this comment for the "not any" case and also the
scopeInfo's relation to the member. Is this the scope[info] in which this member
is defined?

https://codereview.chromium.org/2988553003/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:507: /// Collected [ScopeInof] data
for nodes.
ScopeInof->ScopeInfo

[Johnni Winther, 2017-07-28 13:48:57]

Description was changed from

==========
Compute closure model purely from IR nodes

- and convert it to the J-model afterwards.
==========

to

==========
Compute closure model purely from IR nodes

- and convert it to the J-model afterwards.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6e280fc4f441d21ced2590cd3f7097c5dc22889f
==========

[Johnni Winther, 2017-07-28 13:48:58]

Committed patchset #2 (id:20001) manually as
6e280fc4f441d21ced2590cd3f7097c5dc22889f (presubmit successful).

[Johnni Winther, 2017-08-02 08:03:14]

https://codereview.chromium.org/2988553003/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/closure.dart (right):

https://codereview.chromium.org/2988553003/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:69: // TODO(johnniwinther,efortuna):
Compute this during resolution.
On 2017/07/26 18:04:23, Emily Fortuna wrote:
> see also the existing documentation on convertClosures

Done.

https://codereview.chromium.org/2988553003/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:500: /// Collection [ScopeInfo] data
for the member, if any.
On 2017/07/26 18:04:23, Emily Fortuna wrote:
> please add clarification in this comment for the "not any" case and also the
> scopeInfo's relation to the member. Is this the scope[info] in which this
member
> is defined?

The 'not any' case seems to be an inconsistency in the skipping of fields
without initializers, added a TODO.

https://codereview.chromium.org/2988553003/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/closure.dart:507: /// Collected [ScopeInof] data
for nodes.
On 2017/07/26 18:04:22, Emily Fortuna wrote:
> ScopeInof->ScopeInfo

Done.