Task manager tracking RenderProcessHosts processes

chrome/browser/task_manager/providers/child_process_task.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager/providers/child_process_task.h"
 
 #include <utility>
 
+#include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/process_resource_usage.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/task_manager/task_manager_observer.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/theme_resources.h"
 #include "components/nacl/common/nacl_process_type.h"
 #include "content/public/browser/browser_child_process_host.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/common/child_process_host.h"
 #include "content/public/common/process_type.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/common/extension_set.h"
@@ skipping 66 matching lines @@
           if (extension) {
             result_title = base::UTF8ToUTF16(extension->name());
             break;
           }
         }
       }
       return l10n_util::GetStringFUTF16(IDS_TASK_MANAGER_NACL_PREFIX,
                                         result_title);
     }
     // These types don't need display names or get them from elsewhere.
     case content::PROCESS_TYPE_BROWSER:

[ncarter (slow), 2017/07/26 21:22:34]

The fallthrough behavior of 'case' labels means that we'll return "Render
Process Host" for PROCESS_TYPE_BROWSER. Is that intentional?

[cburn, 2017/07/27 19:28:29]

It was not, fixed now. 

     case content::PROCESS_TYPE_RENDERER:
+      if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+              switches::kEnableAggressiveProcessTracking)) {

[ncarter (slow), 2017/07/26 21:22:34]

Is this code actually reachable without the command line switch?

If so, then I don't think we actually want to return "Render Process Host" in
the cases where it was reachable before.

If not, then I don't think we need to check for the presence of the command line
switch.

[cburn, 2017/07/27 19:28:29]

As far as I can tell I don't think it is hit and is one of the types that
doesn't need a display name.

+        return base::ASCIIToUTF16("Render Process Host");

[ncarter (slow), 2017/07/26 21:22:34]

Users will see this, so we will need to get this string translated (
http://dev.chromium.org/developers/design-documents/ui-localization ) so that it
appears correctly in other locales. This can be done now, or left as a TODO, but
it'll be a requirement before we can remove the flag.

Render Process Host is probably too jargony to ask the translators to do
something with. Let's talk face-to-face about what to do here.

[cburn, 2017/07/27 19:28:29]

Sounds good. 

+      }
     case content::PROCESS_TYPE_ZYGOTE:
     case content::PROCESS_TYPE_SANDBOX_HELPER:
     case content::PROCESS_TYPE_MAX:
       break;
     case content::PROCESS_TYPE_UNKNOWN:
       NOTREACHED() << "Need localized name for child process type.";
   }
 
   return result_title;
 }
@@ skipping 89 matching lines @@
       return Task::UTILITY;
     case content::PROCESS_TYPE_ZYGOTE:
       return Task::ZYGOTE;
     case content::PROCESS_TYPE_SANDBOX_HELPER:
       return Task::SANDBOX_HELPER;
     case content::PROCESS_TYPE_GPU:
       return Task::GPU;
     case PROCESS_TYPE_NACL_LOADER:
     case PROCESS_TYPE_NACL_BROKER:
       return Task::NACL;
+    case content::PROCESS_TYPE_RENDERER:
+      return Task::RENDERER;
     default:
       return Task::UNKNOWN;
   }
 }
 
 int ChildProcessTask::GetChildProcessUniqueID() const {
   return unique_child_process_id_;
 }
 
 bool ChildProcessTask::ReportsV8Memory() const {
   return uses_v8_memory_ && process_resources_sampler_->ReportsV8MemoryStats();
 }
 
 int64_t ChildProcessTask::GetV8MemoryAllocated() const {
   return v8_memory_allocated_;
 }
 
 int64_t ChildProcessTask::GetV8MemoryUsed() const {
   return v8_memory_used_;
 }
 
 }  // namespace task_manager