Task manager tracking RenderProcessHosts processes

chrome/browser/task_manager/providers/child_process_task.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager/providers/child_process_task.h"
 
 #include <utility>
 
+#include "base/command_line.h"
 #include "base/i18n/rtl.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/process_resource_usage.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/task_manager/task_manager_observer.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/grit/theme_resources.h"
 #include "components/nacl/common/nacl_process_type.h"
 #include "content/public/browser/browser_child_process_host.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/common/child_process_host.h"
 #include "content/public/common/process_type.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/common/extension_set.h"
@@ skipping 65 matching lines @@
               enabled_extensions.GetExtensionOrAppByURL(GURL(result_title));
           if (extension) {
             result_title = base::UTF8ToUTF16(extension->name());
             break;
           }
         }
       }
       return l10n_util::GetStringFUTF16(IDS_TASK_MANAGER_NACL_PREFIX,
                                         result_title);
     }
+    case content::PROCESS_TYPE_RENDERER: {
+      // TODO: (cburn) Start the UI Localization process for this. Currently the

[Charlie Reis, 2017/08/02 18:39:14]

nit: Slight syntax fix:

TODO(cburn): 

Also, let's move the TODO inside the conditional, since it only matters when the
flag is present.

[cburn, 2017/08/04 16:39:53]

Done.

+      // best name for this is "Renderer".
+      if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+              switches::kTaskManagerShowExtraRenderers)) {
+        return base::ASCIIToUTF16("Renderer");
+      }
+    }
     // These types don't need display names or get them from elsewhere.
     case content::PROCESS_TYPE_BROWSER:
-    case content::PROCESS_TYPE_RENDERER:
     case content::PROCESS_TYPE_ZYGOTE:
     case content::PROCESS_TYPE_SANDBOX_HELPER:
     case content::PROCESS_TYPE_MAX:
       break;
     case content::PROCESS_TYPE_UNKNOWN:
       NOTREACHED() << "Need localized name for child process type.";
   }
 
   return result_title;
 }
@@ skipping 89 matching lines @@
       return Task::UTILITY;
     case content::PROCESS_TYPE_ZYGOTE:
       return Task::ZYGOTE;
     case content::PROCESS_TYPE_SANDBOX_HELPER:
       return Task::SANDBOX_HELPER;
     case content::PROCESS_TYPE_GPU:
       return Task::GPU;
     case PROCESS_TYPE_NACL_LOADER:
     case PROCESS_TYPE_NACL_BROKER:
       return Task::NACL;
+    case content::PROCESS_TYPE_RENDERER:
+      return Task::RENDERER;
     default:
       return Task::UNKNOWN;
   }
 }
 
 int ChildProcessTask::GetChildProcessUniqueID() const {
   return unique_child_process_id_;
 }
 
 bool ChildProcessTask::ReportsV8Memory() const {
   return uses_v8_memory_ && process_resources_sampler_->ReportsV8MemoryStats();
 }
 
 int64_t ChildProcessTask::GetV8MemoryAllocated() const {
   return v8_memory_allocated_;
 }
 
 int64_t ChildProcessTask::GetV8MemoryUsed() const {
   return v8_memory_used_;
 }
 
 }  // namespace task_manager