Issue 298843003: Reorder checks in Runtime_TypedArrayInitialize*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 298843003: Reorder checks in Runtime_TypedArrayInitialize* (Closed)

Created:
6 years, 7 months ago by Jakob Kummerow

Modified:
6 years, 7 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Reorder checks in Runtime_TypedArrayInitialize* All checks must be performed before any side effects, so we get atomic transactions BUG=chromium:374443 LOG=n R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21410

Patch Set 3 : typo #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -23 lines)			Patch
	M	src/runtime.cc	View	1 2	6 chunks	+26 lines, -23 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

lgtm, small aesthetics nit. https://codereview.chromium.org/298843003/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/298843003/diff/1/src/runtime.cc#newcode1020 src/runtime.cc:1020: ASSERT(holder->GetInternalFieldCount() == Nit: could you ...

6 years, 7 months ago (2014-05-21 11:02:46 UTC) #2

Dmitry Lomov (no reviews)

On 2014/05/21 12:28:52, Jakob wrote: > Refactored as discussed. Do you like this better? lgtm, ...

6 years, 7 months ago (2014-05-21 12:30:03 UTC) #4

Jakob Kummerow

6 years, 7 months ago (2014-05-21 12:36:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r21410 (presubmit successful).

Expand Messages | Collapse Messages

Issue 298843003: Reorder checks in Runtime_TypedArrayInitialize* (Closed)

Description

Patch Set 1 #

Patch Set 2 : refactored #

Patch Set 3 : typo #

Messages