Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2988423002: Add more targets to run_tests based on experience in blocks 7 and 8 (Closed)

Created:
3 years, 4 months ago by jcollins
Modified:
3 years, 4 months ago
Reviewers:
*Bob Nystrom
CC:
reviews_dartlang.org, dart2now-team_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more targets to run_tests based on experience in blocks 7 and 8 BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/481ce5813cf814b3ed597fc3d351cc8b2b68adf1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M tools/migration/bin/run_tests.dart View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jcollins
3 years, 4 months ago (2017-08-03 17:55:32 UTC) #3
Bob Nystrom
LGTM++!
3 years, 4 months ago (2017-08-03 18:30:59 UTC) #4
jcollins
3 years, 4 months ago (2017-08-03 18:39:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
481ce5813cf814b3ed597fc3d351cc8b2b68adf1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698