Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: pkg/status_file/test/status_expression_test.dart

Issue 2988383002: A minimal status file formatter and canonicalizer. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/status_file/test/status_expression_test.dart
diff --git a/pkg/status_file/test/status_expression_test.dart b/pkg/status_file/test/status_expression_test.dart
index d641e2ba08772ebd4c656c0ce25e69698d25617a..e10969d9013e913a3892f3526dcc8a31c26e72af 100644
--- a/pkg/status_file/test/status_expression_test.dart
+++ b/pkg/status_file/test/status_expression_test.dart
@@ -33,8 +33,7 @@ main() {
void testExpression() {
var expression = Expression
.parse(r" $mode == debug && ($arch == chromium || $arch == dartc) ");
- Expect.equals(
- r"(($mode == debug) && (($arch == chromium) || ($arch == dartc)))",
+ Expect.equals(r"$mode == debug && ($arch == chromium || $arch == dartc)",
expression.toString());
// Test BooleanExpression.evaluate().
@@ -61,8 +60,8 @@ void testSyntaxError() {
void testBoolean() {
var expression =
Expression.parse(r" $arch == ia32 && $checked || $mode == release ");
- Expect.equals(r"((($arch == ia32) && (bool $checked)) || ($mode == release))",
- expression.toString());
+ Expect.equals(
+ r"$arch == ia32 && $checked || $mode == release", expression.toString());
// Test BooleanExpression.evaluate().
var environment =
@@ -85,8 +84,7 @@ void testNotBoolean() {
var expression =
Expression.parse(r" $arch == ia32 && ! $checked || $mode == release ");
Expect.equals(
- r"((($arch == ia32) && (bool ! $checked)) || ($mode == release))",
- expression.toString());
+ r"$arch == ia32 && !$checked || $mode == release", expression.toString());
var environment = new TestEnvironment(
{"arch": "ia32", "checked": "false", "mode": "debug"});
@@ -108,7 +106,7 @@ void testNotEqual() {
// Test the != operator.
var expression = Expression.parse(r"$compiler == dart2js && $runtime != ie9");
Expect.equals(
- r"(($compiler == dart2js) && ($runtime != ie9))", expression.toString());
+ r"$compiler == dart2js && $runtime != ie9", expression.toString());
// Test BooleanExpression.evaluate().
var environment = new TestEnvironment({
« pkg/status_file/lib/status_file.dart ('K') | « pkg/status_file/lib/status_file.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698