A minimal status file formatter and canonicalizer.

A minimal status file formatter and canonicalizer.

For the migration script, I need a (less hacky) way of programmatically
modifying a status file. As a step along that path, I need the ability
to write a status file to disc given a StatusFile object.

With that, it was a small step to write a little "formatter" that turns
a status file into its canonical representation.

It removes unneeded parentheses in expressions, normalizes expectation
case, and normalizes whitespace. Seems useful.

R=whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/b9795ffabbf2c2d8e24ef9b0dfdd0de42b3a64c3

[Bob Nystrom, 2017-08-02 22:59:36]

rnystrom@google.com changed reviewers:
+ whesse@google.com

[Bill Hesse, 2017-08-03 14:24:07]

lgtm

https://codereview.chromium.org/2988383002/diff/1/pkg/status_file/lib/status_...
File pkg/status_file/lib/status_file.dart (right):

https://codereview.chromium.org/2988383002/diff/1/pkg/status_file/lib/status_...
pkg/status_file/lib/status_file.dart:233: for (var entry in section.entries) {
Not in the printing, but as a separate stage, I think you need to sort the
entries and eliminate duplicates.  So the comments should go with the entries,
not just line numbers.

[Bob Nystrom, 2017-08-03 20:28:49]

https://codereview.chromium.org/2988383002/diff/1/pkg/status_file/lib/status_...
File pkg/status_file/lib/status_file.dart (right):

https://codereview.chromium.org/2988383002/diff/1/pkg/status_file/lib/status_...
pkg/status_file/lib/status_file.dart:233: for (var entry in section.entries) {
On 2017/08/03 14:24:07, Bill Hesse wrote:
> Not in the printing, but as a separate stage, I think you need to sort the
> entries and eliminate duplicates.

Yeah, I thought of that after I sent this out. I may do that at some point, but
this CL marked an easy point where I had something that worked. Sorting adds
complexity since you have to deal with comments and blank lines in the middle of
sections.

> So the comments should go with the entries, not just line numbers.

Yeah, I considered that too. I'll probably re-work the way comments are tracked
if we support sorting or modifying status files programmatically. The latter was
my real motivation for adding this.

[Bob Nystrom, 2017-08-03 20:37:34]

Description was changed from

==========
A minimal status file formatter and canonicalizer.

For the migration script, I need a (less hacky) way of programmatically
modifying a status file. As a step along that path, I need the ability
to write a status file to disc given a StatusFile object.

With that, it was a small step to write a little "formatter" that turns
a status file into its canonical representation.

It removes unneeded parentheses in expressions, normalizes expectation
case, and normalizes whitespace. Seems useful.
==========

to

==========
A minimal status file formatter and canonicalizer.

For the migration script, I need a (less hacky) way of programmatically
modifying a status file. As a step along that path, I need the ability
to write a status file to disc given a StatusFile object.

With that, it was a small step to write a little "formatter" that turns
a status file into its canonical representation.

It removes unneeded parentheses in expressions, normalizes expectation
case, and normalizes whitespace. Seems useful.

R=whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b9795ffabbf2c2d8e24ef9b0dfdd0de42b3a64c3
==========

[Bob Nystrom, 2017-08-03 20:37:37]

Committed patchset #1 (id:1) manually as
b9795ffabbf2c2d8e24ef9b0dfdd0de42b3a64c3 (presubmit successful).