Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart

Issue 2988373002: Store parts in Kernel Library, resynthesize parts in Analyzer. (Closed)
Patch Set: Fixes for review comments. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart b/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
index 561dc42ae2d29c0c1ea46ba2707d2a20fb2f994d..13d0932116fb73bc2df0621df8ddaab54ea87e8d 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart
@@ -123,26 +123,6 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
- test_class_interfaces_unresolved() async {
- // Fasta generates additional `#errors` top-level variable.
- await super.test_class_interfaces_unresolved();
- }
-
- @failingTest
- @fastaProblem
- test_class_mixins_unresolved() async {
- // Fasta generates additional `#errors` top-level variable.
- await super.test_class_mixins_unresolved();
- }
-
- @failingTest
- @fastaProblem
- test_class_supertype_unresolved() async {
- // Fasta generates additional `#errors` top-level variable.
- await super.test_class_supertype_unresolved();
- }
-
- @failingTest
@fastaProblem
test_class_type_parameters_bound() async {
// Fasta does not provide a flag for explicit vs. implicit Object bound.
@@ -157,11 +137,6 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
- test_closure_in_variable_declaration_in_part() async {
- await super.test_closure_in_variable_declaration_in_part();
- }
-
- @failingTest
@fastaProblem
test_const_invalid_field_const() async {
// Fasta generates additional `#errors` top-level variable.
@@ -472,11 +447,6 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
- test_function_entry_point_in_part() async {
- await super.test_function_entry_point_in_part();
- }
-
- @failingTest
test_genericFunction_asGenericFunctionReturnType() async {
await super.test_genericFunction_asGenericFunctionReturnType();
}
@@ -580,11 +550,6 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
- test_inferredType_definedInSdkLibraryPart() async {
- await super.test_inferredType_definedInSdkLibraryPart();
- }
-
- @failingTest
test_instantiateToBounds_boundRefersToEarlierTypeArgument() async {
await super.test_instantiateToBounds_boundRefersToEarlierTypeArgument();
}
@@ -657,13 +622,6 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
- @fastaProblem
- test_invalid_setterParameter_fieldFormalParameter_self() async {
- // https://github.com/dart-lang/sdk/issues/30267
- await super.test_invalid_setterParameter_fieldFormalParameter_self();
- }
-
- @failingTest
test_invalidUri_part_emptyUri() async {
await super.test_invalidUri_part_emptyUri();
}
@@ -771,11 +729,6 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
}
@failingTest
- test_parts() async {
- await super.test_parts();
- }
-
- @failingTest
test_parts_invalidUri() async {
await super.test_parts_invalidUri();
}
@@ -1050,36 +1003,6 @@ class ResynthesizeKernelStrongTest extends ResynthesizeTest {
await super.test_unresolved_import();
}
- @failingTest
- test_unresolved_part() async {
- await super.test_unresolved_part();
- }
-
- @failingTest
- test_variable_getterInLib_setterInPart() async {
- await super.test_variable_getterInLib_setterInPart();
- }
-
- @failingTest
- test_variable_getterInPart_setterInLib() async {
- await super.test_variable_getterInPart_setterInLib();
- }
-
- @failingTest
- test_variable_getterInPart_setterInPart() async {
- await super.test_variable_getterInPart_setterInPart();
- }
-
- @failingTest
- test_variable_propagatedType_final_dep_inPart() async {
- await super.test_variable_propagatedType_final_dep_inPart();
- }
-
- @failingTest
- test_variable_setterInPart_getterInPart() async {
- await super.test_variable_setterInPart_getterInPart();
- }
-
String _getLibraryText(kernel.Library library) {
StringBuffer buffer = new StringBuffer();
new kernel.Printer(buffer, syntheticNames: new kernel.NameSystem())
« no previous file with comments | « pkg/analyzer/lib/src/kernel/resynthesize.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698