Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2988343002: Initial support for an explicit plugin list (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -33 lines) Patch
M pkg/analysis_server/lib/src/plugin/plugin_watcher.dart View 2 chunks +34 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/status/diagnostics.dart View 6 chunks +18 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_watcher_test.dart View 3 chunks +16 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 5 chunks +17 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This preserves the old code path in order to not delay the angular plugin work.
3 years, 4 months ago (2017-08-02 17:39:04 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-02 18:21:48 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-08-02 18:31:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c635b7b859cdbc768da460993f3470d8ded8b41 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698