[Aura] Reduce frequency of PinchUpdate events.

ui/events/gesture_detection/gesture_provider.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/gesture_detection/gesture_provider.h"
 
 #include <cmath>
 
 #include "base/auto_reset.h"
 #include "base/debug/trace_event.h"
@@ skipping 112 matching lines @@
 // GestureProvider::ScaleGestureListener
 
 class GestureProvider::ScaleGestureListenerImpl
     : public ScaleGestureDetector::ScaleGestureListener {
  public:
   ScaleGestureListenerImpl(const ScaleGestureDetector::Config& config,
                            GestureProvider* provider)
       : scale_gesture_detector_(config, this),
         provider_(provider),
         ignore_multitouch_events_(false),
-        pinch_event_sent_(false) {}
+        pinch_event_sent_(false),
+        min_pinch_update_span_delta_(config.min_pinch_update_span_delta),
+        prev_span_(0) {}
 
   bool OnTouchEvent(const MotionEvent& event) {
     // TODO: Need to deal with multi-touch transition.
     const bool in_scale_gesture = IsScaleGestureDetectionInProgress();
     bool handled = scale_gesture_detector_.OnTouchEvent(event);
     if (!in_scale_gesture &&
         (event.GetAction() == MotionEvent::ACTION_UP ||
          event.GetAction() == MotionEvent::ACTION_CANCEL)) {
       return false;
     }
@@ skipping 20 matching lines @@
                                   0,
                                   e.GetPointerCount(),
                                   GetBoundingBox(e)));
     pinch_event_sent_ = false;
   }
 
   virtual bool OnScale(const ScaleGestureDetector& detector,
                        const MotionEvent& e) OVERRIDE {
     if (ignore_multitouch_events_ && !detector.InDoubleTapMode())
       return false;
+
+    float span = detector.GetCurrentSpan();
+    bool pinch_occured =

[jdduke (slow), 2014/05/22 17:37:24]

Hmm, why are you doing this before the if (!pinch_event_sent_) check? I thought
that's the whole reason we moved this logic here, so that we could get the
PINCH_BEGIN without the PINCH_UPDATE?

I would move this down, before the scale check. Then, just return false if it
fails the threshold test, and use the |GetPreviousSpan()| value from the
ScaleGestureDetector.

[tdresser, 2014/05/22 17:57:22]

Done.

+        std::abs(span - prev_span_) >= min_pinch_update_span_delta_;
+
+    if (!pinch_occured)
+      return true;
+
+    prev_span_ = span;
+
     if (!pinch_event_sent_) {
       pinch_event_sent_ = true;
       provider_->Send(CreateGesture(ET_GESTURE_PINCH_BEGIN,
                                     e.GetId(),
                                     detector.GetEventTime(),
                                     detector.GetFocusX(),
                                     detector.GetFocusY(),
                                     e.GetPointerCount(),
                                     GetBoundingBox(e)));
     }
@@ skipping 56 matching lines @@
 
   GestureProvider* const provider_;
 
   // Completely silence multi-touch (pinch) scaling events. Used in WebView when
   // zoom support is turned off.
   bool ignore_multitouch_events_;
 
   // Whether any pinch zoom event has been sent to native.
   bool pinch_event_sent_;
 
+  // The minimum change in span required before this is considered a pinch. See
+  // crbug.com/373318.
+  float min_pinch_update_span_delta_;
+
+  float prev_span_;

[jdduke (slow), 2014/05/22 17:37:24]

See comment above, we shouldn't need to cache the prev_span_.

[tdresser, 2014/05/22 17:57:22]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(ScaleGestureListenerImpl);
 };
 
 // GestureProvider::GestureListener
 
 class GestureProvider::GestureListenerImpl
     : public GestureDetector::GestureListener,
       public GestureDetector::DoubleTapListener {
  public:
   GestureListenerImpl(
@@ skipping 515 matching lines @@
   if (current_down_event_)
     return;
 
   const bool double_tap_enabled = double_tap_support_for_page_ &&
                                   double_tap_support_for_platform_;
   gesture_listener_->SetDoubleTapEnabled(double_tap_enabled);
   scale_gesture_listener_->SetDoubleTapEnabled(double_tap_enabled);
 }
 
 }  //  namespace ui