Issue 2988213002: Moving test that was not moved automatically by migration script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2988213002: Moving test that was not moved automatically by migration script. (Closed)

Created:
3 years, 4 months ago by bkonyi

Modified:
3 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Moving test that was not moved automatically by migration script. TBR=rnystrom@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/232a6330d8ac87487209167fa5b3d062d6a445c6

Patch Set 1 #

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	A	tests/corelib_2/package_resource_test.dart	View		1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

bkonyi

Committed patchset #1 (id:1) manually as 232a6330d8ac87487209167fa5b3d062d6a445c6 (presubmit successful).

3 years, 4 months ago (2017-07-31 23:03:23 UTC) #2

Bob Nystrom

Wasn't this test deliberately deleted? I didn't think dart:core had a Resource class anymore.

3 years, 4 months ago (2017-08-01 01:31:52 UTC) #3

bkonyi

3 years, 4 months ago (2017-08-01 02:07:53 UTC) #4

Message was sent while issue was closed.

On 2017/08/01 at 01:31:52, rnystrom wrote:
> Wasn't this test deliberately deleted? I didn't think dart:core had a Resource
class anymore.

That would explain a lot. The test was still in corelib{_strong} and started
failing after the status files were updated by the script. I had landed a patch
to just skip the test for now until I could figure out what was up with this
particular test, but I think you've answered that question. I'll remove this
test when I get in tomorrow.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages