Initial implementation of the import-aware copy support

Initial implementation of the import-aware copy support

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/ae69313731eb7f267b3435e3cac31dd6b8bd4020

[Brian Wilkerson, 2017-07-31 21:36:32]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2017-07-31 21:36:33]

I'm especially interested to know whether there are other tests I ought to add.

[scheglov, 2017-07-31 22:08:04]

lgtm

https://codereview.chromium.org/2988183002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/computer/imported_elements_computer.dart
(right):

https://codereview.chromium.org/2988183002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/imported_elements_computer.dart:57:
LibraryElement containingLibrary;
Make all these fields final?

https://codereview.chromium.org/2988183002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/imported_elements_computer.dart:92: Element
nodeElement = node.bestElement;
Hm... I thought that we are interested in names of top-level declarations that
are explicitly written in code. So, these names are always statically resolved.
So, maybe this should be "node.staticElement".

https://codereview.chromium.org/2988183002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/imported_elements_computer.dart:96: if
(nodeLibrary != containingLibrary) {
Why not?

If we copy a use of a class defined in the library A from the library A to the
library B, we want to insert an import of A into B. OTOH, if we paste into A, we
don't need to re-import itself.

So, this check should be moved to paste.

https://codereview.chromium.org/2988183002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/imported_elements_computer.dart:104:
Element prefixElement = prefixIdentifier.bestElement;
Same here - prefixes are resolved statically.

[Brian Wilkerson, 2017-08-01 14:44:15]

ptal

https://codereview.chromium.org/2988183002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/computer/imported_elements_computer.dart
(right):

https://codereview.chromium.org/2988183002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/imported_elements_computer.dart:57:
LibraryElement containingLibrary;
Not sure I see the point, given that they're in a private class, but done.

https://codereview.chromium.org/2988183002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/imported_elements_computer.dart:92: Element
nodeElement = node.bestElement;
Done

https://codereview.chromium.org/2988183002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/imported_elements_computer.dart:96: if
(nodeLibrary != containingLibrary) {
Good point. Done.

https://codereview.chromium.org/2988183002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/computer/imported_elements_computer.dart:104:
Element prefixElement = prefixIdentifier.bestElement;
Done

[scheglov, 2017-08-01 15:16:35]

LGTM

https://codereview.chromium.org/2988183002/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/src/computer/imported_elements_computer_test.dart
(right):

https://codereview.chromium.org/2988183002/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/src/computer/imported_elements_computer_test.dart:30:
test_dartAsync_noPrefix() async {
I would add a test for using a class defined in the same library.

[Brian Wilkerson, 2017-08-01 15:31:43]

https://codereview.chromium.org/2988183002/diff/20001/pkg/analysis_server/tes...
File pkg/analysis_server/test/src/computer/imported_elements_computer_test.dart
(right):

https://codereview.chromium.org/2988183002/diff/20001/pkg/analysis_server/tes...
pkg/analysis_server/test/src/computer/imported_elements_computer_test.dart:30:
test_dartAsync_noPrefix() async {
Done

[Brian Wilkerson, 2017-08-01 15:32:16]

Description was changed from

==========
Initial implementation of the import-aware copy support
==========

to

==========
Initial implementation of the import-aware copy support

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ae69313731eb7f267b3435e3cac31dd6b8bd4020
==========

[Brian Wilkerson, 2017-08-01 15:32:17]

Committed patchset #2 (id:20001) manually as
ae69313731eb7f267b3435e3cac31dd6b8bd4020 (presubmit successful).