Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: ui/views/button_drag_utils.cc

Issue 298813002: views: Move MenuButton from TextButton to LabelButton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Try fixing linux compile wrt NewAvatarButton. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/button_drag_utils.cc
diff --git a/ui/views/button_drag_utils.cc b/ui/views/button_drag_utils.cc
index 0084ba9cca6b556f63f786368a67775524950260..199de7fde15f1c289b019917da09203ef7a048c8 100644
--- a/ui/views/button_drag_utils.cc
+++ b/ui/views/button_drag_utils.cc
@@ -10,6 +10,7 @@
#include "ui/base/dragdrop/os_exchange_data.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/canvas.h"
+#include "ui/gfx/geometry/point.h"
#include "ui/gfx/image/image.h"
#include "ui/views/controls/button/text_button.h"
#include "ui/views/drag_utils.h"
@@ -18,17 +19,25 @@
namespace button_drag_utils {
// Maximum width of the link drag image in pixels.
-static const int kLinkDragImageMaxWidth = 200;
+static const int kLinkDragImageMaxWidth = 150;
void SetURLAndDragImage(const GURL& url,
const base::string16& title,
const gfx::ImageSkia& icon,
+ const gfx::Point* press_pt,
ui::OSExchangeData* data,
views::Widget* widget) {
DCHECK(url.is_valid() && data);
-
data->SetURL(url, title);
+ SetDragImage(url, title, icon, press_pt, data, widget);
+}
+void SetDragImage(const GURL& url,
+ const base::string16& title,
+ const gfx::ImageSkia& icon,
+ const gfx::Point* press_pt,
+ ui::OSExchangeData* data,
+ views::Widget* widget) {
// Create a button to render the drag image for us.
views::TextButton button(NULL,
title.empty() ? base::UTF8ToUTF16(url.spec())
@@ -43,12 +52,18 @@ void SetURLAndDragImage(const GURL& url,
gfx::Size prefsize = button.GetPreferredSize();
button.SetBounds(0, 0, prefsize.width(), prefsize.height());
+ gfx::Vector2d press_point;
+ if (press_pt)
+ press_point = press_pt->OffsetFromOrigin();
+ else
+ press_point = gfx::Vector2d(prefsize.width() / 2, prefsize.height() / 2);
+
// Render the image.
scoped_ptr<gfx::Canvas> canvas(
views::GetCanvasForDragImage(widget, prefsize));
button.PaintButton(canvas.get(), views::TextButton::PB_FOR_DRAG);
drag_utils::SetDragImageOnDataObject(*canvas, prefsize,
- gfx::Vector2d(prefsize.width() / 2, prefsize.height() / 2), data);
+ press_point, data);
msw 2014/06/11 00:55:46 nit: fits on line above.
}
} // namespace button_drag_utils

Powered by Google App Engine
This is Rietveld 408576698