Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_view.cc

Issue 298813002: views: Move MenuButton from TextButton to LabelButton. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove stray LOG Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_selector_view.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_selector_view.cc b/chrome/browser/ui/views/website_settings/permission_selector_view.cc
index 883fc38508f4b31f1cd554a5c5b10bb0ed33d3c8..89b80ed795b7b42d8513028e649e47089498d3da 100644
--- a/chrome/browser/ui/views/website_settings/permission_selector_view.cc
+++ b/chrome/browser/ui/views/website_settings/permission_selector_view.cc
@@ -45,9 +45,6 @@ class PermissionMenuButton : public views::MenuButton,
bool show_menu_marker);
virtual ~PermissionMenuButton();
- // Overridden from views::MenuButton.
- virtual gfx::Size GetPreferredSize() const OVERRIDE;
-
// Overridden from views::TextButton.
virtual void SetText(const base::string16& text) OVERRIDE;
@@ -74,33 +71,17 @@ PermissionMenuButton::PermissionMenuButton(const base::string16& text,
bool show_menu_marker)
: MenuButton(NULL, text, this, show_menu_marker),
menu_model_(model) {
- SetEnabledColor(GetNativeTheme()->GetSystemColor(
+ SetTextColor(views::Button::STATE_NORMAL, GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_LabelEnabledColor));
- SetHoverColor(GetNativeTheme()->GetSystemColor(
+ SetTextColor(views::Button::STATE_HOVERED, GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_LabelEnabledColor));
- SetDisabledColor(GetNativeTheme()->GetSystemColor(
+ SetTextColor(views::Button::STATE_DISABLED, GetNativeTheme()->GetSystemColor(
ui::NativeTheme::kColorId_LabelDisabledColor));
}
PermissionMenuButton::~PermissionMenuButton() {
}
-gfx::Size PermissionMenuButton::GetPreferredSize() const {
- gfx::Insets insets = GetInsets();
- // Scale the button to the current text size.
- gfx::Size prefsize(text_size_.width() + insets.width(),
- text_size_.height() + insets.height());
- if (max_width_ > 0)
- prefsize.set_width(std::min(max_width_, prefsize.width()));
- if (show_menu_marker()) {
- prefsize.Enlarge(menu_marker()->width() +
- views::MenuButton::kMenuMarkerPaddingLeft +
- views::MenuButton::kMenuMarkerPaddingRight,
- 0);
- }
- return prefsize;
-}
-
void PermissionMenuButton::SetText(const base::string16& text) {
MenuButton::SetText(text);
SizeToPreferredSize();
@@ -108,7 +89,7 @@ void PermissionMenuButton::SetText(const base::string16& text) {
void PermissionMenuButton::GetAccessibleState(ui::AXViewState* state) {
MenuButton::GetAccessibleState(state);
- state->value = text();
+ state->value = GetText();
}
void PermissionMenuButton::OnMenuButtonClicked(View* source,

Powered by Google App Engine
This is Rietveld 408576698