views: Move MenuButton from TextButton to LabelButton.

ui/views/button_drag_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/button_drag_utils.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ui_resources.h"
 #include "ui/base/dragdrop/drag_utils.h"
 #include "ui/base/dragdrop/os_exchange_data.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/image/image.h"
 #include "ui/views/controls/button/text_button.h"
 #include "ui/views/drag_utils.h"
 #include "url/gurl.h"
 
 namespace button_drag_utils {
 
 // Maximum width of the link drag image in pixels.
-static const int kLinkDragImageMaxWidth = 200;
+static const int kLinkDragImageMaxWidth = 150;

[msw, 2014/06/09 17:18:40]

Why are you changing this?

[Elliot Glaysher, 2014/06/11 00:27:28]

As mentioned above, this is being set to BookmarkBarView::kMaxButtonWidth.
Otherwise, we create a drag image larger than the button we're dragging from.

 
 void SetURLAndDragImage(const GURL& url,
                         const base::string16& title,
                         const gfx::ImageSkia& icon,
                         ui::OSExchangeData* data,
                         views::Widget* widget) {
   DCHECK(url.is_valid() && data);
 
   data->SetURL(url, title);
 
@@ skipping 13 matching lines @@
 
   // Render the image.
   scoped_ptr<gfx::Canvas> canvas(
       views::GetCanvasForDragImage(widget, prefsize));
   button.PaintButton(canvas.get(), views::TextButton::PB_FOR_DRAG);
   drag_utils::SetDragImageOnDataObject(*canvas, prefsize,
       gfx::Vector2d(prefsize.width() / 2, prefsize.height() / 2), data);
 }
 
 }  // namespace button_drag_utils