Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2988113002: Add Class.isEnum to Kernel and use it to resynthesize enums in Analyzer. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Class.isEnum to Kernel and use it to resynthesize enums in Analyzer. R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e64115f93fd12bb42ad1487ec1c55426f51b985f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -49 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 13 chunks +80 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/kernel/resynthesize.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 3 chunks +0 lines, -25 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/lib/ast.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/kernel/lib/binary/ast_from_binary.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/kernel/lib/binary/ast_to_binary.dart View 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 4 months ago (2017-07-28 21:29:46 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-07-28 21:34:03 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 4 months ago (2017-07-31 17:22:50 UTC) #3
scheglov
3 years, 4 months ago (2017-07-31 17:34:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e64115f93fd12bb42ad1487ec1c55426f51b985f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698