Print Preview: Enable PrintPreviewTest on Linux ASAN.

Print Preview: Enable PrintPreviewTest on Linux ASAN.

Fix an easily reproducible crash that happens locally in the PDF plugin.

BUG=375126
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275534

[Lei Zhang, 2014-05-22 04:43:09]

When you run the test locally, you can see the system print dialog popping up
instead of the print preview dialog.

[Lei Zhang, 2014-05-22 04:49:39]

On 2014/05/22 04:43:09, Lei Zhang wrote:
> When you run the test locally, you can see the system print dialog popping up
> instead of the print preview dialog.

Err, I read the bug again and noticed it was for ASAN. I don't even know how
these tests are passing as is. They don't work right for me here. I'll try with
ASAN and hopefully fix that too...

[jam, 2014-05-28 17:33:59]

On 2014/05/22 04:49:39, Lei Zhang wrote:
> On 2014/05/22 04:43:09, Lei Zhang wrote:
> > When you run the test locally, you can see the system print dialog popping
up
> > instead of the print preview dialog.
> 
> Err, I read the bug again and noticed it was for ASAN. I don't even know how
> these tests are passing as is. They don't work right for me here. I'll try
with
> ASAN and hopefully fix that too...

btw i'm not sure i understand, is this ready for me ot review or are you waiting
to change it?

[Lei Zhang, 2014-05-28 17:36:09]

On 2014/05/28 17:33:59, jam wrote:
> On 2014/05/22 04:49:39, Lei Zhang wrote:
> > On 2014/05/22 04:43:09, Lei Zhang wrote:
> > > When you run the test locally, you can see the system print dialog popping
> up
> > > instead of the print preview dialog.
> > 
> > Err, I read the bug again and noticed it was for ASAN. I don't even know how
> > these tests are passing as is. They don't work right for me here. I'll try
> with
> > ASAN and hopefully fix that too...
> 
> btw i'm not sure i understand, is this ready for me ot review or are you
waiting
> to change it?

No, I had some trouble with ASAN last week. I'll ping you again when this is
ready.

[Lei Zhang, 2014-06-06 05:59:12]

PTAL at patch set 2. I've been testing this locally and the NULL pointer deref
as a result of an ImageData being an invalid resource is the only thing I'm
hitting.

[jam, 2014-06-06 14:49:42]

lgtm

[Lei Zhang, 2014-06-06 18:19:25]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-06 18:21:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/298803010/20001

[commit-bot: I haz the power, 2014-06-06 21:49:05]

Change committed as 275534