Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 298803009: Remove no-op did(De)activateCompositor calls (Closed)

Created:
6 years, 7 months ago by enne (OOO)
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Remove no-op did(De)activateCompositor calls These have been removed in Chrome and do nothing. R=jochen@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175725

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M Source/web/WebPagePopupImpl.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/web/WebPopupMenuImpl.cpp View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 4 chunks +0 lines, -5 lines 0 comments Download
M public/web/WebWidgetClient.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
enne (OOO)
These will actually be no-ops once https://codereview.chromium.org/296513010/ lands.
6 years, 7 months ago (2014-05-21 22:54:26 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-22 08:36:40 UTC) #2
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 6 months ago (2014-05-30 17:23:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/298803009/20001
6 years, 6 months ago (2014-05-30 17:24:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-05-30 18:40:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 19:15:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6546)
6 years, 6 months ago (2014-05-30 19:15:48 UTC) #7
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 6 months ago (2014-05-30 19:20:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/298803009/20001
6 years, 6 months ago (2014-05-30 19:21:40 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-05-30 23:01:06 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-31 00:16:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/22384)
6 years, 6 months ago (2014-05-31 00:16:10 UTC) #12
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 6 months ago (2014-06-03 00:35:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/298803009/20001
6 years, 6 months ago (2014-06-03 00:36:21 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 00:36:29 UTC) #15
commit-bot: I haz the power
Failed to apply patch for Source/web/WebPopupMenuImpl.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-03 00:36:30 UTC) #16
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 6 months ago (2014-06-06 22:54:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/298803009/40001
6 years, 6 months ago (2014-06-06 22:55:20 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-07 00:21:03 UTC) #19
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 03:38:00 UTC) #20
Message was sent while issue was closed.
Change committed as 175725

Powered by Google App Engine
This is Rietveld 408576698