Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Unified Diff: content/common/view_messages.h

Issue 298803006: NetInfo V3 support for browser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comment in network_change_notifier Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index ae8ea61d07b1c8932208e598b09049b17f5e6365..cc1aa0317db4028063aef5588e1f9f343fd201d7 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -36,6 +36,7 @@
#include "media/audio/audio_parameters.h"
#include "media/base/channel_layout.h"
#include "media/base/media_log_event.h"
+#include "net/base/network_change_notifier.h"
#include "third_party/WebKit/public/platform/WebFloatPoint.h"
#include "third_party/WebKit/public/platform/WebFloatRect.h"
#include "third_party/WebKit/public/platform/WebScreenInfo.h"
@@ -841,10 +842,11 @@ IPC_MESSAGE_ROUTED0(ViewMsg_WorkerScriptLoadFailed)
// This message is sent only if the worker successfully loaded the script.
IPC_MESSAGE_ROUTED0(ViewMsg_WorkerConnected)
-// Tells the renderer that the network state has changed and that
-// window.navigator.onLine should be updated for all WebViews.
-IPC_MESSAGE_CONTROL1(ViewMsg_NetworkStateChanged,
- bool /* online */)
+// Tells the renderer that the network state has changed so that
+// navigator.onLine navigator.connection can be updated.
Tom Sepez 2014/05/28 17:40:16 nit: Did you intend to replace navigator.onLine wi
jkarlin 2014/05/28 18:00:46 Thanks, forgot 'and'.
+IPC_MESSAGE_CONTROL2(ViewMsg_NetworkStateChanged,
+ bool /* is_online */,
+ net::NetworkChangeNotifier::ConnectionType /* type */)
// Reply to ViewHostMsg_OpenChannelToPpapiBroker
// Tells the renderer that the channel to the broker has been created.

Powered by Google App Engine
This is Rietveld 408576698