NetInfo V3 support for browser

Sends NetworkChangeNotifier connection type changes to Blink, to support NetInfo v3.

Design doc: https://docs.google.com/a/chromium.org/document/d/1LTk9uVMGi4kurzcF5ellsAJReTF31fFJMHrQwSVtBjc/

BUG=368358
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273555

[jkarlin, 2014-05-22 15:01:46]

brettw: Please review everything
pauljensen: Please review net/
adamk: Please review changes to navigator.onLine plumbing

[pauljensen, 2014-05-22 15:27:31]

net/ lgtm

[jkarlin, 2014-05-23 11:13:31]

Ping brettw and adamk

[adamk, 2014-05-23 22:29:41]

plumbing changes (webpreferences etc) lgtm, but I'll defer to brettw on the IPC
stuff (I think it's been years since I've touched a Chromium IPC)

[jkarlin, 2014-05-27 13:32:01]

Ping brettw, thanks!

[brettw, 2014-05-27 18:26:36]

lgtm

https://codereview.chromium.org/298803006/diff/110001/net/base/network_change...
File net/base/network_change_notifier.h (right):

https://codereview.chromium.org/298803006/diff/110001/net/base/network_change...
net/base/network_change_notifier.h:38: CONNECTION_UNKNOWN = 0, // A connection
exists, but its type is unknown.
It seems like this comment is wrong given that the network change notifier also
returns this if you request the status before its initialized (in which case you
may have no connection). Is this also your understanding? Can we clarify this?

[jkarlin, 2014-05-27 18:44:37]

https://codereview.chromium.org/298803006/diff/110001/net/base/network_change...
File net/base/network_change_notifier.h (right):

https://codereview.chromium.org/298803006/diff/110001/net/base/network_change...
net/base/network_change_notifier.h:38: CONNECTION_UNKNOWN = 0, // A connection
exists, but its type is unknown.
On 2014/05/27 18:26:36, brettw wrote:
> It seems like this comment is wrong given that the network change notifier
also
> returns this if you request the status before its initialized (in which case
you
> may have no connection). Is this also your understanding? Can we clarify this?

I think you're right. Updated the comment.

[jkarlin, 2014-05-27 18:52:00]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-05-27 18:52:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/298803006/130001

[jkarlin, 2014-05-27 20:52:58]

kinuko@chromium.org: Please review changes in webkit/common

tsepez@chromium.org: Please review changes in content/common and content/public

Thanks!

[commit-bot: I haz the power, 2014-05-27 21:45:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-27 21:47:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 21:47:38]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[kinuko, 2014-05-28 06:16:59]

webkit/ lgtm

[Tom Sepez, 2014-05-28 17:40:15]

messages LGTM with nit.

https://codereview.chromium.org/298803006/diff/130001/content/common/view_mes...
File content/common/view_messages.h (right):

https://codereview.chromium.org/298803006/diff/130001/content/common/view_mes...
content/common/view_messages.h:846: // navigator.onLine navigator.connection can
be updated.
nit: Did you intend to replace navigator.onLine with navigator.connection in
this comment?

https://codereview.chromium.org/298803006/diff/130001/content/public/common/c...
File content/public/common/common_param_traits_macros.h (right):

https://codereview.chromium.org/298803006/diff/130001/content/public/common/c...
content/public/common/common_param_traits_macros.h:32:
IPC_ENUM_TRAITS_MIN_MAX_VALUE(net::NetworkChangeNotifier::ConnectionType,
nit: you can use the shorter _MAX_VALUE() form here since CONNECTION_UNKNOWN is
0.  Alternatively, if you're concerned about someone coming along and sticking
in a -1 value in the spec someday, then you might consider defining a
CONNECTION_FIRST using the same trick as CONNECTION_LAST.

https://codereview.chromium.org/298803006/diff/130001/net/base/network_change...
File net/base/network_change_notifier.h (right):

https://codereview.chromium.org/298803006/diff/130001/net/base/network_change...
net/base/network_change_notifier.h:40: CONNECTION_ETHERNET = 1,
nit: maybe CONNECTION_FIRST = CONNECTION_UNKNOWN here if you want to use the
_MIN_MAX_VALUE() form.

[jkarlin, 2014-05-28 18:00:45]

https://codereview.chromium.org/298803006/diff/130001/content/common/view_mes...
File content/common/view_messages.h (right):

https://codereview.chromium.org/298803006/diff/130001/content/common/view_mes...
content/common/view_messages.h:846: // navigator.onLine navigator.connection can
be updated.
On 2014/05/28 17:40:16, Tom Sepez wrote:
> nit: Did you intend to replace navigator.onLine with navigator.connection in
> this comment? 

Thanks, forgot 'and'.

https://codereview.chromium.org/298803006/diff/130001/content/public/common/c...
File content/public/common/common_param_traits_macros.h (right):

https://codereview.chromium.org/298803006/diff/130001/content/public/common/c...
content/public/common/common_param_traits_macros.h:32:
IPC_ENUM_TRAITS_MIN_MAX_VALUE(net::NetworkChangeNotifier::ConnectionType,
On 2014/05/28 17:40:16, Tom Sepez wrote:
> nit: you can use the shorter _MAX_VALUE() form here since CONNECTION_UNKNOWN
is
> 0.  Alternatively, if you're concerned about someone coming along and sticking
> in a -1 value in the spec someday, then you might consider defining a
> CONNECTION_FIRST using the same trick as CONNECTION_LAST.

Done.

https://codereview.chromium.org/298803006/diff/130001/net/base/network_change...
File net/base/network_change_notifier.h (right):

https://codereview.chromium.org/298803006/diff/130001/net/base/network_change...
net/base/network_change_notifier.h:40: CONNECTION_ETHERNET = 1,
On 2014/05/28 17:40:16, Tom Sepez wrote:
> nit: maybe CONNECTION_FIRST = CONNECTION_UNKNOWN here if you want to use the
> _MIN_MAX_VALUE() form.

Went with MAX_VALUE instead, thanks!

[jkarlin, 2014-05-28 18:00:52]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-05-28 18:01:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/298803006/160001

[commit-bot: I haz the power, 2014-05-28 21:01:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-28 21:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 21:05:41]

Try jobs failed on following builders:
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[jkarlin, 2014-05-28 21:37:00]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-05-28 21:38:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/298803006/160001

[commit-bot: I haz the power, 2014-05-28 21:49:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-05-28 21:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 21:55:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[jkarlin, 2014-05-29 01:05:34]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-05-29 01:07:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/298803006/160001

[jkarlin, 2014-05-29 01:14:43]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-05-29 01:16:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/298803006/180001

[jkarlin, 2014-05-29 01:19:30]

The CQ bit was unchecked by jkarlin@chromium.org

[jkarlin, 2014-05-29 01:34:07]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2014-05-29 01:35:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jkarlin@chromium.org/298803006/200001

[commit-bot: I haz the power, 2014-05-29 19:50:31]

Change committed as 273555