Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: telemetry/telemetry/internal/actions/play_unittest.py

Issue 2988013003: Disable failing media unittests on chromeos. (Closed)
Patch Set: Update bug Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/actions/play_unittest.py
diff --git a/telemetry/telemetry/internal/actions/play_unittest.py b/telemetry/telemetry/internal/actions/play_unittest.py
index c497cf9915c91335ad64bbb89b940ae241cc1a31..b73b06cf3b5e483cc202702c9c691d0668ad2bbc 100644
--- a/telemetry/telemetry/internal/actions/play_unittest.py
+++ b/telemetry/telemetry/internal/actions/play_unittest.py
@@ -20,7 +20,8 @@ class PlayActionTest(tab_test_case.TabTestCase):
tab_test_case.TabTestCase.setUp(self)
self.Navigate('video_test.html')
- @decorators.Disabled('android', 'linux') # crbug.com/418577
+ # crbug.com/749890
+ @decorators.Disabled('android', 'linux', 'chromeos')
def testPlayWithNoSelector(self):
"""Tests that with no selector Play action plays first video element."""
action = play.PlayAction(playing_event_timeout_in_seconds=5)
@@ -33,7 +34,8 @@ class PlayActionTest(tab_test_case.TabTestCase):
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
self.assertFalse(self._tab.EvaluateJavaScript(AUDIO_1_PLAYING_CHECK))
- @decorators.Disabled('android', 'linux') # crbug.com/418577
+ # crbug.com/749890
+ @decorators.Disabled('android', 'linux', 'chromeos')
def testPlayWithVideoSelector(self):
"""Tests that Play action plays video element matching selector."""
action = play.PlayAction(selector='#video_1',
@@ -47,7 +49,8 @@ class PlayActionTest(tab_test_case.TabTestCase):
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
self.assertFalse(self._tab.EvaluateJavaScript(AUDIO_1_PLAYING_CHECK))
- @decorators.Disabled('android', 'linux') # crbug.com/418577
+ # crbug.com/749890
+ @decorators.Disabled('android', 'linux', 'chromeos')
def testPlayWithAllSelector(self):
"""Tests that Play action plays all video elements with selector='all'."""
action = play.PlayAction(selector='all',
@@ -61,8 +64,7 @@ class PlayActionTest(tab_test_case.TabTestCase):
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
self.assertTrue(self._tab.EvaluateJavaScript(AUDIO_1_PLAYING_CHECK))
- # http://crbug.com/273887
- @decorators.Disabled('linux') # crbug.com/418577
+ @decorators.Disabled('linux', 'chromeos') # crbug.com/749890
def testPlayWaitForPlayTimeout(self):
"""Tests that wait_for_playing timeouts if video does not play."""
action = play.PlayAction(selector='#video_1',
@@ -72,7 +74,8 @@ class PlayActionTest(tab_test_case.TabTestCase):
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_PLAYING_CHECK))
self.assertRaises(py_utils.TimeoutException, action.RunAction, self._tab)
- @decorators.Disabled('android', 'linux') # crbug.com/418577
+ # crbug.com/749890
+ @decorators.Disabled('android', 'linux', 'chromeos')
def testPlayWaitForEnded(self):
"""Tests that wait_for_ended waits for video to end."""
action = play.PlayAction(selector='#video_1',
@@ -85,7 +88,7 @@ class PlayActionTest(tab_test_case.TabTestCase):
# Assert video ended.
self.assertTrue(self._tab.EvaluateJavaScript(VIDEO_1_ENDED_CHECK))
- @decorators.Disabled('linux') # crbug.com/418577
+ @decorators.Disabled('linux', 'chromeos') # crbug.com/749890
def testPlayWithoutWaitForEnded(self):
"""Tests that wait_for_ended waits for video to end."""
action = play.PlayAction(selector='#video_1',
@@ -98,7 +101,7 @@ class PlayActionTest(tab_test_case.TabTestCase):
# Assert video did not end.
self.assertFalse(self._tab.EvaluateJavaScript(VIDEO_1_ENDED_CHECK))
- @decorators.Disabled('linux') # crbug.com/418577
+ @decorators.Disabled('linux', 'chromeos') # crbug.com/749890
def testPlayWaitForEndedTimeout(self):
"""Tests that action raises exception if timeout is reached."""
action = play.PlayAction(selector='#video_1',
« no previous file with comments | « telemetry/telemetry/internal/actions/loop_unittest.py ('k') | telemetry/telemetry/internal/actions/seek_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698