Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Unified Diff: telemetry/telemetry/internal/actions/load_media_unittest.py

Issue 2988013003: Disable failing media unittests on chromeos. (Closed)
Patch Set: Update bug Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/internal/actions/loop_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/actions/load_media_unittest.py
diff --git a/telemetry/telemetry/internal/actions/load_media_unittest.py b/telemetry/telemetry/internal/actions/load_media_unittest.py
index 95347afebe58a4820450cc2e78d338f4ceafa7ad..6279b63084aa9f4f52b75b05f026d9a08bdd3396 100644
--- a/telemetry/telemetry/internal/actions/load_media_unittest.py
+++ b/telemetry/telemetry/internal/actions/load_media_unittest.py
@@ -20,8 +20,7 @@ class LoadMediaActionTest(tab_test_case.TabTestCase):
'window.__hasEventCompleted({{ selector }}, {{ event }});',
selector=selector, event=event)
- @decorators.Disabled('linux', # crbug.com/418577
- 'chromeos') # crbug.com/632802
+ @decorators.Disabled('linux', 'chromeos') # crbug.com/749890
def testAwaitedEventIsConfigurable(self):
"""It's possible to wait for different events."""
action = LoadMediaAction(selector='#video_1', timeout_in_seconds=0.1,
@@ -30,7 +29,7 @@ class LoadMediaActionTest(tab_test_case.TabTestCase):
action.RunAction(self._tab)
self.assertTrue(self.eventFired('#video_1', 'loadedmetadata'))
- @decorators.Disabled('linux') # crbug.com/418577
+ @decorators.Disabled('linux', 'chromeos') # crbug.com/749890
def testLoadWithNoSelector(self):
"""With no selector the first media element is loaded."""
action = LoadMediaAction(timeout_in_seconds=5)
@@ -39,7 +38,7 @@ class LoadMediaActionTest(tab_test_case.TabTestCase):
self.assertTrue(self.eventFired('#video_1', 'canplaythrough'))
self.assertFalse(self.eventFired('#audio_1', 'canplaythrough'))
- @decorators.Disabled('linux') # crbug.com/418577
+ @decorators.Disabled('linux', 'chromeos') # crbug.com/749890
def testLoadWithSelector(self):
"""Only the element matching the selector is loaded."""
action = LoadMediaAction(selector='#audio_1', timeout_in_seconds=5)
@@ -48,7 +47,7 @@ class LoadMediaActionTest(tab_test_case.TabTestCase):
self.assertFalse(self.eventFired('#video_1', 'canplaythrough'))
self.assertTrue(self.eventFired('#audio_1', 'canplaythrough'))
- @decorators.Disabled('linux') # crbug.com/418577
+ @decorators.Disabled('linux', 'chromeos') # crbug.com/749890
def testLoadWithAllSelector(self):
"""Both elements are loaded with selector='all'."""
action = LoadMediaAction(selector='all', timeout_in_seconds=5)
@@ -57,7 +56,7 @@ class LoadMediaActionTest(tab_test_case.TabTestCase):
self.assertTrue(self.eventFired('#video_1', 'canplaythrough'))
self.assertTrue(self.eventFired('#audio_1', 'canplaythrough'))
- @decorators.Disabled('linux') # crbug.com/418577
+ @decorators.Disabled('linux', 'chromeos') # crbug.com/749890
def testLoadRaisesAnExceptionOnTimeout(self):
"""The load action times out if the event does not fire."""
action = LoadMediaAction(selector='#video_1', timeout_in_seconds=0.1,
« no previous file with comments | « no previous file | telemetry/telemetry/internal/actions/loop_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698