Issue 30034. Parse annotations for typedef(s) and resynthesize from Kernel in analyzer.

Issue 30034. Parse annotations for typedef(s) and resynthesize from Kernel in analyzer.

R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com
BUG= https://github.com/dart-lang/sdk/issues/30034

Committed: https://github.com/dart-lang/sdk/commit/f9424908a528420346e078a28709e40d809c28c1

[Brian Wilkerson, 2017-07-27 21:02:30]

lgtm

[Siggi Cherem (dart-lang), 2017-07-28 00:05:14]

lgtm with small suggestion below

https://codereview.chromium.org/2987983004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2987983004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:208: var listener =
createListener(typedefBuilder, memberScope, false);
could we pull this out into a common function? It seems to be almost the same as
what we do when parsing annotations in classes.

Possibly:
  void parseMetadata(Builder builder, Scope scope, Token metadata, void
addAnnotation(Expression)) {
  }

so you can call it here as:

   parseMetadata(typedefBuilder, memberScope, metadata,
typedefBuilder.target.addAnnotation);

?

[scheglov, 2017-08-01 17:08:19]

Description was changed from

==========
Issue 30034. Parse annotations for typedef(s) and resynthesize from Kernel in
analyzer.

R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com
BUG= https://github.com/dart-lang/sdk/issues/30034
==========

to

==========
Issue 30034. Parse annotations for typedef(s) and resynthesize from Kernel in
analyzer.

R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com
BUG= https://github.com/dart-lang/sdk/issues/30034

Committed:
https://github.com/dart-lang/sdk/commit/f9424908a528420346e078a28709e40d809c28c1
==========

[scheglov, 2017-08-01 17:08:21]

Committed patchset #1 (id:1) manually as
f9424908a528420346e078a28709e40d809c28c1 (presubmit successful).

[scheglov, 2017-08-01 17:10:21]

https://codereview.chromium.org/2987983004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/source/diet_listener.dart (right):

https://codereview.chromium.org/2987983004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/source/diet_listener.dart:208: var listener =
createListener(typedefBuilder, memberScope, false);
On 2017/07/28 00:05:14, Siggi Cherem (dart-lang) wrote:
> could we pull this out into a common function? It seems to be almost the same
as
> what we do when parsing annotations in classes.
> 
> Possibly:
>   void parseMetadata(Builder builder, Scope scope, Token metadata, void
> addAnnotation(Expression)) {
>   }
> 
> so you can call it here as:
> 
>    parseMetadata(typedefBuilder, memberScope, metadata,
> typedefBuilder.target.addAnnotation);
> 
> ?

Done.