Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 298793002: Rebaseline Alex/Release for FP math with SSE. (Closed)

Created:
6 years, 7 months ago by mtklein_C
Modified:
6 years, 7 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Rebaseline Alex/Release for FP math with SSE. BUG=skia: NOTREECHECKS=true Committed: http://code.google.com/p/skia/source/detail?r=14814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -410 lines) Patch
M expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json View 82 chunks +218 lines, -410 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
lgtm
6 years, 7 months ago (2014-05-20 20:37:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/298793002/1
6 years, 7 months ago (2014-05-20 20:37:56 UTC) #2
mtklein
The CQ bit was unchecked by mtklein@google.com
6 years, 7 months ago (2014-05-20 20:47:50 UTC) #3
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 7 months ago (2014-05-20 20:47:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/298793002/1
6 years, 7 months ago (2014-05-20 20:48:18 UTC) #5
commit-bot: I haz the power
Change committed as 14814
6 years, 7 months ago (2014-05-20 20:48:25 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 20:48:54 UTC) #7
Message was sent while issue was closed. 
Failed to apply patch for
expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json
  Hunk #1 FAILED at 94.
  Hunk #2 FAILED at 142.
  Hunk #3 FAILED at 352.
  Hunk #4 FAILED at 424.
  Hunk #5 FAILED at 466.
  Hunk #6 FAILED at 491.
  Hunk #7 FAILED at 2219.
  Hunk #8 FAILED at 2333.
  Hunk #9 FAILED at 2393.
  Hunk #10 FAILED at 2417.
  Hunk #11 FAILED at 2453.
  Hunk #12 FAILED at 2462.
  Hunk #13 FAILED at 2540.
  Hunk #14 FAILED at 2630.
  Hunk #15 FAILED at 2726.
  Hunk #16 FAILED at 3018.
  Hunk #17 FAILED at 3060.
  Hunk #18 FAILED at 3069.
  Hunk #19 FAILED at 3078.
  Hunk #20 FAILED at 3087.
  Hunk #21 FAILED at 3096.
  Hunk #22 FAILED at 3105.
  Hunk #23 FAILED at 3114.
  Hunk #24 FAILED at 3123.
  Hunk #25 FAILED at 3132.
  Hunk #26 FAILED at 3141.
  Hunk #27 FAILED at 3159.
  Hunk #28 FAILED at 3168.
  Hunk #29 FAILED at 3177.
  Hunk #30 FAILED at 3186.
  Hunk #31 FAILED at 3195.
  Hunk #32 FAILED at 3204.
  Hunk #33 FAILED at 3213.
  Hunk #34 FAILED at 3222.
  Hunk #35 FAILED at 3231.
  Hunk #36 FAILED at 3240.
  Hunk #37 FAILED at 3249.
  Hunk #38 FAILED at 3258.
  Hunk #39 FAILED at 3267.
  Hunk #40 FAILED at 3276.
  Hunk #41 FAILED at 3285.
  Hunk #42 FAILED at 3342.
  Hunk #43 FAILED at 3351.
  Hunk #44 FAILED at 3504.
  Hunk #45 FAILED at 3600.
  Hunk #46 FAILED at 3720.
  Hunk #47 FAILED at 3798.
  Hunk #48 FAILED at 3807.
  Hunk #49 FAILED at 3840.
  Hunk #50 FAILED at 3849.
  Hunk #51 FAILED at 3876.
  Hunk #52 FAILED at 3885.
  Hunk #53 FAILED at 3894.
  Hunk #54 FAILED at 3903.
  Hunk #55 FAILED at 4008.
  Hunk #56 FAILED at 4017.
  Hunk #57 FAILED at 4126.
  Hunk #58 FAILED at 4208.
  Hunk #59 FAILED at 4368.
  Hunk #60 FAILED at 4486.
  Hunk #61 FAILED at 4600.
  Hunk #62 FAILED at 4609.
  Hunk #63 FAILED at 4991.
  Hunk #64 FAILED at 5031.
  Hunk #65 FAILED at 5040.
  Hunk #66 FAILED at 5205.
  Hunk #67 FAILED at 5214.
  Hunk #68 FAILED at 5239.
  Hunk #69 FAILED at 5248.
  Hunk #70 FAILED at 5431.
  Hunk #71 FAILED at 5473.
  Hunk #72 FAILED at 5569.
  Hunk #73 FAILED at 5578.
  Hunk #74 FAILED at 5662.
  Hunk #75 FAILED at 5698.
  Hunk #76 FAILED at 6014.
  Hunk #77 FAILED at 6047.
  Hunk #78 FAILED at 6234.
  Hunk #79 FAILED at 6414.
  Hunk #80 FAILED at 6432.
  Hunk #81 FAILED at 6486.
  Hunk #82 FAILED at 6495.
  82 out of 82 hunks FAILED -- saving rejects to file
expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json.rej

Patch:      
expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json
Index:
expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json
diff --git
a/expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json
b/expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json
index
900329b8d0fd09ef8368e29eb173cf8dff52e07c..8bad6a49de36191d197df1972a516fa44abeb8c6
100644
---
a/expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json
+++
b/expectations/gm/Test-ChromeOS-Alex-GMA3150-x86-Release/expected-results.json
@@ -94,25 +94,19 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          495458940800121980
+          14297291255102949024
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "arcofzorro_8888.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          7871844485538418123
+          12650638297902351267
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "arithmode_565.png": {
       "allowed-digests": [
@@ -142,25 +136,19 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          6335392589185658049
+          13864700347231029854
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "bicubicfilter_8888.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          4597733902801636738
+          10469536215464879914
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "bigbitmaprect_i_565.png": {
       "allowed-digests": [
@@ -352,49 +340,37 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          18096603530409620115
+          18028564147828277613
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "bitmaprect_i_8888.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          10732507724426853062
+          14065905418589114539
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "bitmaprect_s_565.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          18096603530409620115
+          18028564147828277613
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "bitmaprect_s_8888.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          10732507724426853062
+          14065905418589114539
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "bitmaprecttest_565.png": {
       "allowed-digests": [
@@ -424,25 +400,19 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          14300389632090005942
+          747939669746474090
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "bitmapscroll_8888.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          9294115299060557575
+          12765000964251560878
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "bitmapshaders_565.png": {
       "allowed-digests": [
@@ -466,23 +436,25 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          12736083110271149224
+          17582560710025270339
         ]
-      ]
+      ], 
+      "reviewed-by-human": true
     }, 
     "bitmapsource_8888.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          13886238950789909117
+          12787133954682325160
         ]
-      ]
+      ], 
+      "reviewed-by-human": true
     }, 
     "bleed_565.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          4757052398172304660
+          1844781142419806112
         ]
       ], 
       "reviewed-by-human": true
@@ -491,7 +463,7 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          17960406194138620622
+          749193672577578009
         ]
       ], 
       "reviewed-by-human": true
@@ -2219,19 +2191,19 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          14026603725131815249
+          16287621504408228135
         ]
       ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "convex_poly_clip_8888.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          15375594987467567183
+          13751296096684188541
         ]
       ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "convexpaths_565.png": {
       "allowed-digests": [
@@ -2333,49 +2305,37 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          14745137536800571946
+          1243485597747942942
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "dashcubics_8888.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          10677081072764536898
+          561323664416995153
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "dashing2_565.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          1567336071542865941
+          7522047842497784488
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "dashing2_8888.png": {
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          505820502163537204
+          16976334130763507258
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "dashing3_565.png": {
       "allowed-digests": [
@@ -2393,13 +2353,10 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          10177137740509529492
+          2000525185460569669
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "dashing_565.png": {
       "allowed-digests": [
@@ -2417,13 +2374,10 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
-          12975427358347733464
+          11645276935331048518
         ]
       ], 
-      "bugs": [
-        1578
-      ], 
-      "reviewed-by-human": false
+      "reviewed-by-human": true
     }, 
     "degeneratesegments_565.png": {
       "allowed-digests": [
@@ -2453,7 +2407,7 @@
       "allowed-digests": [
         [
           "bitmap-64bitMD5", 
…
(message too large)

Powered by Google App Engine
This is Rietveld 408576698