Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2987883003: Resynthesize top-level accessors and variables from Kernel. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -78 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 3 chunks +46 lines, -28 lines 0 comments Download
M pkg/analyzer/lib/src/kernel/resynthesize.dart View 1 chunk +67 lines, -0 lines 2 comments Download
M pkg/analyzer/test/src/summary/element_text.dart View 2 chunks +9 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 4 chunks +0 lines, -45 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 4 months ago (2017-07-26 18:09:03 UTC) #1
Brian Wilkerson
lgtm. Feel free to ignore the naming nits. https://codereview.chromium.org/2987883003/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart File pkg/analyzer/lib/src/kernel/resynthesize.dart (right): https://codereview.chromium.org/2987883003/diff/1/pkg/analyzer/lib/src/kernel/resynthesize.dart#newcode392 pkg/analyzer/lib/src/kernel/resynthesize.dart:392: for ...
3 years, 4 months ago (2017-07-26 18:17:11 UTC) #2
scheglov
3 years, 4 months ago (2017-07-26 18:29:16 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f7e81325d86b3eecf3604c641b17e25059f201b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698