Issue 2987883002: Don't treat unparseable files as presubmit dartfmt errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2987883002: Don't treat unparseable files as presubmit dartfmt errors. (Closed)

Created:
3 years, 5 months ago by Bob Nystrom

Modified:
3 years, 5 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org, dart2now-team_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Don't treat unparseable files as presubmit dartfmt errors. If the file has a syntax error, it can't be formatted. We don't want to block submission on that since we do have lots of files in the repo that deliberately contain syntax errors. R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/cc1f6a7a35ca7d029d8588608df9962ca061d914

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -18 lines)			Patch
	M	PRESUBMIT.py	View		1 chunk	+14 lines, -18 lines	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

3 years, 5 months ago (2017-07-26 00:05:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cc1f6a7a35ca7d029d8588608df9962ca061d914 (presubmit successful).