[fuchsia, arm64] Use mx_cache_flush instead of removed __clear_cache.

[fuchsia, arm64] Use mx_cache_flush instead of removed __clear_cache.

Committed: https://github.com/dart-lang/sdk/commit/7fb4a5bc45aedf518d5e3f1654cf76e3d580e852

[rmacnak, 2017-07-25 22:29:51]

rmacnak@google.com changed reviewers:
+ mcgrathr@google.com, zra@google.com

[Roland McGrath, 2017-07-25 22:34:24]

mcgrathr@chromium.org changed reviewers:
+ mcgrathr@chromium.org

[Roland McGrath, 2017-07-25 22:34:24]

https://codereview.chromium.org/2987873002/diff/1/runtime/vm/cpu_arm64.cc
File runtime/vm/cpu_arm64.cc (right):

https://codereview.chromium.org/2987873002/diff/1/runtime/vm/cpu_arm64.cc#new...
runtime/vm/cpu_arm64.cc:44: // mx_status result = mx_cache_flush(start, size,
MX_CACHE_FLUSH_INSN);
This should build now and the Magenta runtime support will probably land within
a day, so I think you could just enable this now.

[rmacnak, 2017-07-25 22:38:15]

https://codereview.chromium.org/2987873002/diff/1/runtime/vm/cpu_arm64.cc
File runtime/vm/cpu_arm64.cc (right):

https://codereview.chromium.org/2987873002/diff/1/runtime/vm/cpu_arm64.cc#new...
runtime/vm/cpu_arm64.cc:44: // mx_status result = mx_cache_flush(start, size,
MX_CACHE_FLUSH_INSN);
On 2017/07/25 22:34:24, Roland McGrath wrote:
> This should build now and the Magenta runtime support will probably land
within
> a day, so I think you could just enable this now.

I can't call it now because the current implementation is a trap instead of
no-op.

[Roland McGrath, 2017-07-25 22:47:50]

On 2017/07/25 22:38:15, rmacnak wrote:
> https://codereview.chromium.org/2987873002/diff/1/runtime/vm/cpu_arm64.cc
> File runtime/vm/cpu_arm64.cc (right):
> 
>
https://codereview.chromium.org/2987873002/diff/1/runtime/vm/cpu_arm64.cc#new...
> runtime/vm/cpu_arm64.cc:44: // mx_status result = mx_cache_flush(start, size,
> MX_CACHE_FLUSH_INSN);
> On 2017/07/25 22:34:24, Roland McGrath wrote:
> > This should build now and the Magenta runtime support will probably land
> within
> > a day, so I think you could just enable this now.
> 
> I can't call it now because the current implementation is a trap instead of
> no-op.

It's landed in Magenta now.

[rmacnak, 2017-07-25 22:50:48]

Description was changed from

==========
[fuchsia, arm64] Don't call removed __clear_cache, and disable code collection
to decrease the likelyhood of encountering a problem because of the missing
I-cache flush.
==========

to

==========
[fuchsia, arm64] Use mx_cache_flush instead of removed __clear_cache.
==========

[rmacnak, 2017-07-25 23:02:23]

On 2017/07/25 22:47:50, Roland McGrath wrote:
> On 2017/07/25 22:38:15, rmacnak wrote:
> > https://codereview.chromium.org/2987873002/diff/1/runtime/vm/cpu_arm64.cc
> > File runtime/vm/cpu_arm64.cc (right):
> > 
> >
>
https://codereview.chromium.org/2987873002/diff/1/runtime/vm/cpu_arm64.cc#new...
> > runtime/vm/cpu_arm64.cc:44: // mx_status result = mx_cache_flush(start,
size,
> > MX_CACHE_FLUSH_INSN);
> > On 2017/07/25 22:34:24, Roland McGrath wrote:
> > > This should build now and the Magenta runtime support will probably land
> > within
> > > a day, so I think you could just enable this now.
> > 
> > I can't call it now because the current implementation is a trap instead of
> > no-op.
> 
> It's landed in Magenta now.

Updated to call mx_cache_flush.

[rmacnak, 2017-07-25 23:07:46]

Description was changed from

==========
[fuchsia, arm64] Use mx_cache_flush instead of removed __clear_cache.
==========

to

==========
[fuchsia, arm64] Use mx_cache_flush instead of removed __clear_cache.

Committed:
https://github.com/dart-lang/sdk/commit/7fb4a5bc45aedf518d5e3f1654cf76e3d580e852
==========

[rmacnak, 2017-07-25 23:07:47]

Committed patchset #3 (id:40001) manually as
7fb4a5bc45aedf518d5e3f1654cf76e3d580e852 (presubmit successful).

[zra, 2017-07-25 23:45:55]

lgtm