Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2987773002: Migrated test block 25 to Dart 2.0. (Closed)

Created:
3 years, 5 months ago by bkonyi
Modified:
3 years, 5 months ago
Reviewers:
Bob Nystrom, jcollins
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 25 to Dart 2.0. Simple block, no real changes. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/b5caf1f5a09b59592c50599157feea7f3b33204d

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed changes to migrate_batch.dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1372 lines) Patch
D tests/corelib/regress_11099_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/corelib/regress_r21715_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/corelib/safe_to_string_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib/set_containsAll_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/corelib/set_contains_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/corelib/set_intersection_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib/set_iterator_test.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D tests/corelib/set_removeAll_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/corelib/set_remove_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/corelib/set_retainAll_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/corelib/set_to_string_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 4 chunks +4 lines, -0 lines 0 comments Download
A + tests/corelib_2/regress_11099_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/regress_r21715_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/safe_to_string_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/set_containsAll_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/set_contains_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/set_intersection_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/set_iterator_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/set_removeAll_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/set_remove_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/set_retainAll_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/set_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A + tests/corelib_2/set_to_string_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/corelib_strong/regress_11099_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/corelib_strong/regress_r21715_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/corelib_strong/safe_to_string_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/corelib_strong/set_containsAll_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/corelib_strong/set_contains_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/corelib_strong/set_intersection_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib_strong/set_iterator_test.dart View 1 chunk +0 lines, -146 lines 0 comments Download
D tests/corelib_strong/set_removeAll_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/corelib_strong/set_remove_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/corelib_strong/set_retainAll_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/corelib_strong/set_test.dart View 1 chunk +0 lines, -545 lines 0 comments Download
D tests/corelib_strong/set_to_string_test.dart View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bkonyi
3 years, 5 months ago (2017-07-24 21:22:15 UTC) #2
bkonyi
3 years, 5 months ago (2017-07-24 21:22:16 UTC) #3
jcollins
https://codereview.chromium.org/2987773002/diff/1/tools/migration/bin/migrate_batch.dart File tools/migration/bin/migrate_batch.dart (right): https://codereview.chromium.org/2987773002/diff/1/tools/migration/bin/migrate_batch.dart#newcode16 tools/migration/bin/migrate_batch.dart:16: import 'package:migration/src/status_file.dart'; This looks like changes from another branch? ...
3 years, 5 months ago (2017-07-25 15:33:12 UTC) #4
bkonyi
On 2017/07/25 15:33:12, jcollins wrote: > https://codereview.chromium.org/2987773002/diff/1/tools/migration/bin/migrate_batch.dart > File tools/migration/bin/migrate_batch.dart (right): > > https://codereview.chromium.org/2987773002/diff/1/tools/migration/bin/migrate_batch.dart#newcode16 > ...
3 years, 5 months ago (2017-07-25 17:56:12 UTC) #5
Bob Nystrom
LGTM!
3 years, 5 months ago (2017-07-25 22:36:22 UTC) #6
bkonyi
3 years, 5 months ago (2017-07-26 00:00:28 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b5caf1f5a09b59592c50599157feea7f3b33204d.

Powered by Google App Engine
This is Rietveld 408576698