Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2987573002: Modify class definition in interpreter (Closed)

Created:
3 years, 5 months ago by zhivkag
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Modify class definition in interpreter according to spec: - Populate implicit getters and setters. - Populate instance methods, getters and setters. BUG= R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/3e563c6e9e3814948b49eb4ef408471829f69b85

Patch Set 1 #

Patch Set 2 : Superclass as one word #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -42 lines) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 2 chunks +39 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
zhivkag
This change modifies the class definition in the interpreter to populate implicit getters and setters, ...
3 years, 5 months ago (2017-07-21 08:04:07 UTC) #3
Dmitry Stefantsov
LGTM
3 years, 5 months ago (2017-07-21 10:32:52 UTC) #4
zhivkag
3 years, 5 months ago (2017-07-21 10:37:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3e563c6e9e3814948b49eb4ef408471829f69b85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698