Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2987563003: Land D8 6.1.0 again, avoid using D8 Worker (Closed)

Created:
3 years, 5 months ago by sra1
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M sdk/lib/_internal/js_runtime/lib/preambles/d8.js View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/d8/README.google View 1 1 chunk +10 lines, -6 lines 0 comments Download
M third_party/d8/linux/d8.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/d8/linux/d8-arm.sha1 View 1 1 chunk +0 lines, -1 line 0 comments Download
A third_party/d8/linux/natives_blob.bin.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/linux/snapshot_blob.bin.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/d8/windows/d8.exe.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/d8/windows/natives_blob.bin.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/d8/windows/snapshot_blob.bin.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
3 years, 5 months ago (2017-07-20 21:14:56 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-07-20 21:31:26 UTC) #3
sra1
3 years, 5 months ago (2017-07-20 21:59:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
487a9048fdf857da7e8fdbf5e7bd15861b241901 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698