Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 298753005: Remove 1/2 pixel offsets for distance field layout. (Closed)

Created:
6 years, 7 months ago by jvanverth1
Modified:
6 years, 7 months ago
Reviewers:
bungeman-skia, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Remove 1/2 pixel offsets for distance field layout. The 1/2 pixel offsets are for rounding when snapping the glyphs to integer boundaries. Since we're using subpixel layout and sampled textures, we shouldn't snap to integer boundaries. BUG=skia:2173 Committed: http://code.google.com/p/skia/source/detail?r=14828

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 4 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jvanverth1
6 years, 7 months ago (2014-05-21 17:08:07 UTC) #1
jvanverth1
Adding Mike.
6 years, 7 months ago (2014-05-21 17:59:43 UTC) #2
reed1
lgtm
6 years, 7 months ago (2014-05-21 18:08:02 UTC) #3
bungeman-skia
Over in SkDraw, we add half the sampling frequency (which means 1/2 for integer, 1/8 ...
6 years, 7 months ago (2014-05-21 18:11:34 UTC) #4
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 7 months ago (2014-05-21 18:19:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/298753005/1
6 years, 7 months ago (2014-05-21 18:21:58 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 19:44:26 UTC) #7
Message was sent while issue was closed.
Change committed as 14828

Powered by Google App Engine
This is Rietveld 408576698