Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2987503003: Further integration of front end type inference into analyzer. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Further integration of front end type inference into analyzer. This CL propagates types from top level variable declarations into analyzer ASTs. This required adding a finishFields method to parser listeners (and a corresponding method DietListener.listenerFinishFields which calls it); this allows AnalyzerDietListener to thread the types through from the BodyBuilder to the AstBuilder. This is similar to what we were already doing for methods. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a93aee1a08135797a0cbae100bdcf68640e08be4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -68 lines) Patch
M pkg/analyzer/lib/src/fasta/analyzer_diet_listener.dart View 3 chunks +71 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/resolution_applier.dart View 2 chunks +27 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/resolution_storer.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 2 chunks +6 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 3 chunks +13 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/ast_builder.status View 13 chunks +0 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-07-19 23:14:04 UTC) #2
scheglov
lgtm
3 years, 5 months ago (2017-07-19 23:48:49 UTC) #3
Paul Berry
3 years, 5 months ago (2017-07-20 06:00:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a93aee1a08135797a0cbae100bdcf68640e08be4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698