Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2987403002: Allow multiple inputs to compare-failures (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
Dmitry Stefantsov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow multiple inputs to compare-failures - and ensure that TestFailure is created with the BuildResult.buildUri R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/baed6581094c487eeec1d9a398f96b3d4559787f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M tools/gardening/bin/compare_failures.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/gardening/lib/src/buildbot_loading.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gardening/lib/src/buildbot_structures.dart View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-03 09:41:50 UTC) #2
Dmitry Stefantsov
LGTM
3 years, 4 months ago (2017-08-03 09:48:05 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-03 10:24:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
baed6581094c487eeec1d9a398f96b3d4559787f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698