enable batch mode for dartdevc tests, also fix status so ddc bots pass

tools/testing/dart/command_output.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:convert';
 // We need to use the 'io' prefix here, otherwise io.exitCode will shadow
 // CommandOutput.exitCode in subclasses of CommandOutput.
 import 'dart:io' as io;
 
 import 'package:status_file/expectation.dart';
@@ skipping 680 matching lines @@
       assert(exitCode != 0);
       return Expectation.compileTimeError;
     }
 
     var outcome =
         exitCode == 0 ? Expectation.pass : Expectation.compileTimeError;
     return _negateOutcomeIfNegativeTest(outcome, testCase.isNegative);
   }
 }
 
+class DevCompilerCommandOutput extends CommandOutput {
+  DevCompilerCommandOutput(
+      Command command,
+      int exitCode,
+      bool timedOut,
+      List<int> stdout,
+      List<int> stderr,
+      Duration time,
+      bool compilationSkipped,
+      int pid)
+      : super(command, exitCode, timedOut, stdout, stderr, time,
+            compilationSkipped, pid);
+
+  Expectation result(TestCase testCase) {
+    if (hasCrashed) return Expectation.crash;
+    if (hasTimedOut) return Expectation.timeout;
+    if (hasNonUtf8) return Expectation.nonUtf8Error;
+
+    // Handle errors / missing errors
+    if (testCase.expectCompileError) {
+      return exitCode != 0

[Bob Nystrom, 2017/08/03 18:28:04]

How about "== 0" and flipping the cases to avoid the mental negation?

[Jennifer Messerly, 2017/08/03 19:43:06]

Done.

+          ? Expectation.pass
+          : Expectation.missingCompileTimeError;
+    }
+
+    // TODO(jmesserly): should we handle `testCase.isNegative`? Analyzer does
+    // not, so this behavior is chosen to match.
+    return exitCode == 0 ? Expectation.pass : Expectation.compileTimeError;
+  }
+}
+
 class KernelCompilationCommandOutput extends CompilationCommandOutput {
   KernelCompilationCommandOutput(
       Command command,
       int exitCode,
       bool timedOut,
       List<int> stdout,
       List<int> stderr,
       Duration time,
       bool compilationSkipped)
       : super(command, exitCode, timedOut, stdout, stderr, time,
@@ skipping 86 matching lines @@
     return new KernelCompilationCommandOutput(
         command, exitCode, timedOut, stdout, stderr, time, compilationSkipped);
   } else if (command is AdbPrecompilationCommand) {
     return new VMCommandOutput(
         command, exitCode, timedOut, stdout, stderr, time, pid);
   } else if (command is CompilationCommand) {
     if (command.displayName == 'precompiler' ||
         command.displayName == 'app_jit') {
       return new VMCommandOutput(
           command, exitCode, timedOut, stdout, stderr, time, pid);
+    } else if (command.displayName == 'dartdevc') {
+      return new DevCompilerCommandOutput(command, exitCode, timedOut, stdout,
+          stderr, time, compilationSkipped, pid);
     }
     return new CompilationCommandOutput(
         command, exitCode, timedOut, stdout, stderr, time, compilationSkipped);
   } else if (command is JSCommandlineCommand) {
     return new JSCommandLineOutput(
         command, exitCode, timedOut, stdout, stderr, time);
   }
 
   return new CommandOutput(command, exitCode, timedOut, stdout, stderr, time,
       compilationSkipped, pid);
@@ skipping 14 matching lines @@
     // complete successfully, it's outcome is Expectation.FAIL.
     // TODO: maybe we should introduce a AsyncIncomplete marker or so
     if (outcome == Expectation.pass) {
       if (_isAsyncTest(testOutput) && !_isAsyncTestSuccessful(testOutput)) {
         return Expectation.fail;
       }
     }
     return outcome;
   }
 }