enable batch mode for dartdevc tests, also fix status so ddc bots pass

pkg/dev_compiler/lib/src/compiler/command.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:io';
 import 'package:analyzer/src/command_line/arguments.dart'
     show
         defineAnalysisArguments,
         filterUnknownArguments,
         ignoreUnrecognizedFlagsFlag;
@@ skipping 263 matching lines @@
 /// Thrown when the input source code has errors.
 class CompileErrorException implements Exception {
   toString() => '\nPlease fix all errors before compiling (warnings are okay).';
 }
 
 /// Thrown when force compilation failed (probably due to static errors).
 class ForceCompileErrorException extends CompileErrorException {
   toString() =>
       '\nForce-compilation not successful. Please check static errors.';
 }
+
+// TODO(jmesserly): fix this function in analyzer
+List<String> filterUnknownArguments(List<String> args, ArgParser parser) {
+  Set<String> knownOptions = new Set<String>();
+  Set<String> knownAbbreviations = new Set<String>();

[Bob Nystrom, 2017/08/03 18:28:04]

No "var"?

[Jennifer Messerly, 2017/08/03 19:43:06]

this is just copied code from Analyzer; obviously I'd never write that! :)

+  parser.options.forEach((String name, option) {
+    knownOptions.add(name);
+    String abbreviation = option.abbreviation;
+    if (abbreviation != null) {
+      knownAbbreviations.add(abbreviation);
+    }
+  });
+  List<String> filtered = <String>[];
+  for (int i = 0; i < args.length; i++) {

[Bob Nystrom, 2017/08/03 18:28:04]

Use a for-in loop?

[Jennifer Messerly, 2017/08/03 19:43:06]

same as above. See TODO, I plan to remove this function and fix the one in
package:analyzer once I can land this CL

+    String argument = args[i];
+    if (argument.startsWith('--') && argument.length > 2) {
+      int equalsOffset = argument.lastIndexOf('=');
+      int end = equalsOffset < 0 ? argument.length : equalsOffset;
+      if (knownOptions.contains(argument.substring(2, end))) {
+        filtered.add(argument);
+      }
+    } else if (argument.startsWith('-') && argument.length > 1) {
+      // TODO(jmesserly): fix this line in analyzer
+      // It was discarding abbreviations such as -Da=b
+      // Abbreviations must be 1-character (this is enforced by ArgParser),
+      // so we don't need to use `optionName`
+      if (knownAbbreviations.contains(argument[1])) {
+        filtered.add(argument);
+      }
+    } else {
+      filtered.add(argument);
+    }
+  }
+  return filtered;
+}