Refactor all gRPC proxy code into a single class.

appengine/swarming/swarming_bot/bot_code/remote_client_grpc.py

 # Copyright 2016 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 # This is a reimplementation of RemoteClientNative but it uses (will use)
 # a gRPC method to communicate with a server instead of REST.
 
 import copy
 import json
 import logging
 import time
 
-import grpc
 import google.protobuf.json_format
 from proto_bot import swarming_bot_pb2
 from remote_client_errors import InternalError
 from remote_client_errors import MintOAuthTokenError
 from remote_client_errors import PollError
 from utils import net
-
-
-# How long to wait for a response from the server. Keeping the same as
-# the equivalent in remote_client.py for now.
-NET_CONNECTION_TIMEOUT_SEC = 5*60
-
-
-# How many times to retry a gRPC call
-MAX_GRPC_ATTEMPTS = 30
-
-
-# Longest time to sleep between gRPC calls
-MAX_GRPC_SLEEP = 10.
+from utils import grpc_proxy
 
 
 class RemoteClientGrpc(object):
   """RemoteClientGrpc knows how to make calls via gRPC.
 
   Any non-scalar value that is returned that references values from the proto
   messages should be deepcopy'd since protos make use of weak references and
   might be garbage-collected before the values are used.
   """
 
-  def __init__(self, server):
+  def __init__(self, server, fake_proxy=None):
     logging.info('Communicating with host %s via gRPC', server)
+    if fake_proxy:
+      self._proxy = fake_proxy
+    else:
+      self._proxy = grpc_proxy.Proxy(server, swarming_bot_pb2.BotServiceStub)
     self._server = server
-    self._channel = grpc.insecure_channel(server)
-    self._stub = swarming_bot_pb2.BotServiceStub(self._channel)
     self._log_is_asleep = False
 
   def is_grpc(self):
     return True
 
   def initialize(self, quit_bit=None):
     pass
 
   @property
   def uses_auth(self):
@@ skipping 19 matching lines @@
       request.output_chunk.data = stdout_and_chunk[0]
       request.output_chunk.offset = stdout_and_chunk[1]
     if exit_code != None:
       request.exit_status.code = exit_code
 
     # Insert everything else. Note that the b64-encoded strings in the dict
     # are automatically decoded by ParseDict.
     google.protobuf.json_format.ParseDict(params, request)
 
     # Perform update
-    response = call_grpc(self._stub.TaskUpdate, request)
+    response = self._proxy.call_unary('TaskUpdate', request)
     logging.debug('post_task_update() = %s', request)
     if response.error:
       raise InternalError(response.error)
     return not response.must_stop
 
   def post_task_error(self, task_id, bot_id, message):
     request = swarming_bot_pb2.TaskErrorRequest()
     request.bot_id = bot_id
     request.task_id = task_id
     request.msg = message
     logging.error('post_task_error() = %s', request)
 
-    response = call_grpc(self._stub.TaskError, request)
+    response = self._proxy.call_unary('TaskError', request)
     return response.ok
 
   def _attributes_json_to_proto(self, json_attr, msg):
     msg.version = json_attr['version']
     for k, values in sorted(json_attr['dimensions'].iteritems()):
       pair = msg.dimensions.add()
       pair.name = k
       pair.values.extend(values)
     create_state_proto(json_attr['state'], msg.state)
 
   def do_handshake(self, attributes):
     request = swarming_bot_pb2.HandshakeRequest()
     self._attributes_json_to_proto(attributes, request.attributes)
-    response = call_grpc(self._stub.Handshake, request)
+    response = self._proxy.call_unary('Handshake', request)
     resp = {
         'server_version': response.server_version,
         'bot_version': response.bot_version,
         'bot_group_cfg_version': response.bot_group_cfg_version,
         'bot_group_cfg': {
             'dimensions': {
                 d.name: d.values for d in response.bot_group_cfg.dimensions
             },
         },
     }
     logging.info('Completed handshake: %s', resp)
     return copy.deepcopy(resp)
 
   def poll(self, attributes):
     request = swarming_bot_pb2.PollRequest()
     self._attributes_json_to_proto(attributes, request.attributes)
     # TODO(aludwin): gRPC-specific exception handling (raise PollError).
-    response = call_grpc(self._stub.Poll, request)
+    response = self._proxy.call_unary('Poll', request)
 
     if response.cmd == swarming_bot_pb2.PollResponse.UPDATE:
       return 'update', response.version
 
     if response.cmd == swarming_bot_pb2.PollResponse.SLEEP:
       if not self._log_is_asleep:
         logging.info('Going to sleep')
         self._log_is_asleep = True
       return 'sleep', response.sleep_time
 
@@ skipping 39 matching lines @@
       self._log_is_asleep = False
       return 'run', copy.deepcopy(manifest)
 
     raise PollError('Unknown command in response: %s' % response)
 
   def get_bot_code(self, new_zip_fn, bot_version, _bot_id):
     # TODO(aludwin): exception handling, pass bot_id
     logging.info('Updating to version: %s', bot_version)
     request = swarming_bot_pb2.BotUpdateRequest()
     request.bot_version = bot_version
-    response = call_grpc(self._stub.BotUpdate, request)
+    response = self._proxy.call_unary('BotUpdate', request)
     with open(new_zip_fn, 'wb') as f:
       f.write(response.bot_code)
 
   def ping(self):
     pass
 
   def mint_oauth_token(self, task_id, bot_id, account_id, scopes):
     # pylint: disable=unused-argument
     raise MintOAuthTokenError(
         'mint_oauth_token is not supported in grpc protocol')
@@ skipping 34 matching lines @@
 
   The keyname for the message field is passed in to simplify the creation
   of the submessage in the first place - you need to say getattr and not
   simply refer to message.keyname since the former actually creates the
   submessage while the latter does not.
   """
   sub_msg = getattr(message, keyname)
   google.protobuf.json_format.Parse(json.dumps(value), sub_msg)
 
 
-def call_grpc(method, request):
-  """Retries a command a set number of times"""
-  for attempt in range(1, MAX_GRPC_ATTEMPTS+1):
-    try:
-      return method(request, timeout=NET_CONNECTION_TIMEOUT_SEC)
-    except grpc.RpcError as g:
-      if g.code() is not grpc.StatusCode.UNAVAILABLE:
-        raise
-      logging.warning('call_grpc - proxy is unavailable (attempt %d/%d)',
-                      attempt, MAX_GRPC_ATTEMPTS)
-      grpc_error = g
-      time.sleep(net.calculate_sleep_before_retry(attempt, MAX_GRPC_SLEEP))
-  # If we get here, it must be because we got (and saved) an error
-  assert grpc_error is not None
-  raise grpc_error