Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: runtime/vm/flow_graph_compiler_dbc.cc

Issue 2987323003: [VM DBC compiler and simulator] Support reified generic functions. (Closed)
Patch Set: sync Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_dbc.cc
diff --git a/runtime/vm/flow_graph_compiler_dbc.cc b/runtime/vm/flow_graph_compiler_dbc.cc
index 06114b23b921b91dfffa90f1522e8b4ec8c13dd0..075fbcb8d86021a7cafc6653899a1b8bd734678c 100644
--- a/runtime/vm/flow_graph_compiler_dbc.cc
+++ b/runtime/vm/flow_graph_compiler_dbc.cc
@@ -406,9 +406,12 @@ void FlowGraphCompiler::EmitFrameEntry() {
// Check for a passed type argument vector if the function is generic.
if (FLAG_reify_generic_functions && function.IsGeneric() &&
!flow_graph().IsCompiledForOsr()) {
- __ Comment("Check passed-in type args");
- UNIMPLEMENTED(); // TODO(regis): Not yet supported.
+ __ CheckFunctionTypeArgs(function.NumTypeParameters(),
+ -parsed_function().first_stack_local_index() - 1);
}
+
+ // TODO(regis): Verify that no vector is passed if not generic, unless already
+ // checked during resolution.
}
void FlowGraphCompiler::CompileGraph() {

Powered by Google App Engine
This is Rietveld 408576698