Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7179)

Unified Diff: chrome/browser/rlz/rlz.cc

Issue 29873005: Implements RLZ lib for iOS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use correct access points enums on iOS Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | rlz/ios/lib/machine_id_ios.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/rlz/rlz.cc
diff --git a/chrome/browser/rlz/rlz.cc b/chrome/browser/rlz/rlz.cc
index dfad49170fc62e8be3db56dc551d338fde0e2452..8738b17072864bc2b98d7831b34cbd6f90778c45 100644
--- a/chrome/browser/rlz/rlz.cc
+++ b/chrome/browser/rlz/rlz.cc
@@ -144,6 +144,13 @@ const rlz_lib::AccessPoint RLZTracker::CHROME_OMNIBOX =
// static
const rlz_lib::AccessPoint RLZTracker::CHROME_HOME_PAGE =
rlz_lib::CHROME_HOME_PAGE;
+#elif defined(OS_IOS)
+// static
+const rlz_lib::AccessPoint RLZTracker::CHROME_OMNIBOX =
+ rlz_lib::CHROME_IOS_OMNIBOX;
Nico 2013/10/23 16:58:27 Does iOS use this class at all?
+// static
+const rlz_lib::AccessPoint RLZTracker::CHROME_HOME_PAGE =
+ rlz_lib::CHROME_IOS_HOME_PAGE;
#elif defined(OS_MACOSX)
// static
const rlz_lib::AccessPoint RLZTracker::CHROME_OMNIBOX =
@@ -228,6 +235,8 @@ bool RLZTracker::InitRlzFromProfileDelayed(Profile* profile,
GURL(pref_service->GetString(prefs::kHomePage)));
bool is_google_in_startpages = false;
+#if !defined(OS_IOS)
+ // iOS does not have a notion of startpages.
SessionStartupPref session_startup_prefs =
StartupBrowserCreator::GetSessionStartupPref(
*CommandLine::ForCurrentProcess(), profile);
@@ -237,6 +246,7 @@ bool RLZTracker::InitRlzFromProfileDelayed(Profile* profile,
session_startup_prefs.urls.end(),
google_util::IsGoogleHomePageUrl) > 0;
}
+#endif
if (!InitRlzDelayed(first_run, send_ping_immediately, delay,
is_google_default_search, is_google_homepage,
« no previous file with comments | « no previous file | rlz/ios/lib/machine_id_ios.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698