Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/gardening/lib/src/buildbot_loading.dart

Issue 2987253002: Add test to compare-failures (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gardening/bin/find_timeouts.dart ('k') | tools/gardening/lib/src/buildbot_structures.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gardening/lib/src/buildbot_loading.dart
diff --git a/tools/gardening/lib/src/buildbot_loading.dart b/tools/gardening/lib/src/buildbot_loading.dart
index 9a2d53ae7751e740fa65e6ae4c81eeeaaf69fd21..b7f478cdc330281fc5492a5d1a54ace4e508ce23 100644
--- a/tools/gardening/lib/src/buildbot_loading.dart
+++ b/tools/gardening/lib/src/buildbot_loading.dart
@@ -32,7 +32,7 @@ Future<BuildResult> _readBuildResult(
}
/// Fetches test data for [buildUri] through the buildbot stdio.
-Future<BuildResult> readBuildResult(
+Future<BuildResult> readBuildResultFromHttp(
HttpClient client, BuildUri buildUri) async {
Future<String> read() async {
Uri uri = buildUri.toUri();
@@ -46,7 +46,7 @@ Future<BuildResult> readBuildResult(
/// Fetches test data for [buildUri] through logdog.
///
/// The build number of [buildUri] most be non-negative.
-Future<BuildResult> readLogDogResult(BuildUri buildUri) {
+Future<BuildResult> readBuildResultFromLogDog(BuildUri buildUri) {
Future<String> read() async {
log('Reading logdog results: $buildUri');
return cat(buildUri.logdogPath);
« no previous file with comments | « tools/gardening/bin/find_timeouts.dart ('k') | tools/gardening/lib/src/buildbot_structures.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698