Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2987253002: Add test to compare-failures (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
Reviewers:
Dmitry Stefantsov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test to compare-failures + support build group names as command-line argument R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/dc83f621996a14f7238ed8c11ad10cb9d7928722

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -168 lines) Patch
M tools/gardening/bin/compare_failures.dart View 4 chunks +11 lines, -120 lines 0 comments Download
M tools/gardening/bin/find_shard.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/gardening/bin/find_timeouts.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/gardening/lib/src/buildbot_loading.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gardening/lib/src/buildbot_structures.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gardening/lib/src/client.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + tools/gardening/lib/src/compare_failures_impl.dart View 2 chunks +44 lines, -38 lines 0 comments Download
M tools/gardening/lib/src/shard_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/gardening/pubspec.yaml View 1 chunk +3 lines, -1 line 0 comments Download
A tools/gardening/test/compare_failures_test.dart View 1 chunk +79 lines, -0 lines 0 comments Download
A tools/gardening/test/test_client.dart View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-01 11:14:10 UTC) #2
Dmitry Stefantsov
These great changes LGTM! I have one question out of curiosity: is it a good ...
3 years, 4 months ago (2017-08-01 11:58:32 UTC) #3
Johnni Winther
On 2017/08/01 11:58:32, Dmitry Stefantsov wrote: > These great changes LGTM! > > I have ...
3 years, 4 months ago (2017-08-02 07:38:13 UTC) #4
Johnni Winther
3 years, 4 months ago (2017-08-02 07:39:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc83f621996a14f7238ed8c11ad10cb9d7928722 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698