Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: pkg/compiler/lib/src/kernel/element_map_impl.dart

Issue 2987233002: Implement hasConcreteMatch (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/element_map_impl.dart
diff --git a/pkg/compiler/lib/src/kernel/element_map_impl.dart b/pkg/compiler/lib/src/kernel/element_map_impl.dart
index da6e337738f1c799d51464858231d81e5f361d50..14b9fcde992e61ee05423c504eb9e9779c5ab9db 100644
--- a/pkg/compiler/lib/src/kernel/element_map_impl.dart
+++ b/pkg/compiler/lib/src/kernel/element_map_impl.dart
@@ -1570,7 +1570,18 @@ abstract class KernelClosedWorldMixin implements ClosedWorldBase {
@override
bool hasConcreteMatch(ClassEntity cls, Selector selector,
{ClassEntity stopAtSuperclass}) {
- throw new UnimplementedError('KernelClosedWorldMixin.hasConcreteMatch');
+ assert(
+ isInstantiated(cls), failedAt(cls, '$cls has not been instantiated.'));
+ MemberEntity element = elementEnvironment
+ .lookupClassMember(cls, selector.name, setter: selector.isSetter);
+ if (element == null) return false;
+
+ if (element.isAbstract) {
+ ClassEntity enclosingClass = element.enclosingClass;
+ return hasConcreteMatch(
+ elementEnvironment.getSuperClass(enclosingClass), selector);
+ }
+ return selector.appliesUntyped(element);
}
@override
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698