Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: src/hydrogen-instructions.h

Issue 298723014: Fix representation inference for mutable double boxes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added TODOs per offline discussion. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-3307.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index 05b31162af5730e4b83bb5844ed1aad40615f823..196f8f0b51d5ee400ef58582f2aecc82f340fa5b 100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -714,6 +714,7 @@ class HValue : public ZoneObject {
if (r.IsTagged()) {
HType t = type();
if (t.IsSmi()) return Representation::Smi();
+ // TODO(mstarzinger): This is not correct for mutable HeapNumbers.
if (t.IsHeapNumber()) return Representation::Double();
if (t.IsHeapObject()) return r;
return Representation::None();
@@ -5503,6 +5504,10 @@ class HAllocate V8_FINAL : public HTemplateInstruction<2> {
return Representation::Integer32();
}
}
+ // TODO(mstarzinger): Workaround until we track mutable HeapNumber types.
+ virtual Representation KnownOptimalRepresentation() V8_OVERRIDE {
+ return representation();
+ }
virtual Handle<Map> GetMonomorphicJSObjectMap() {
return known_initial_map_;
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-3307.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698