Add a script to run the tests in a migration block.

Add a script to run the tests in a migration block.

R=bkonyi@google.com

Committed: https://github.com/dart-lang/sdk/commit/95693b30a33a3882e1ab7fd89551eaccdab44329

[Bob Nystrom, 2017-08-01 01:30:46]

rnystrom@google.com changed reviewers:
+ bkonyi@google.com

[Bob Nystrom, 2017-08-01 01:30:47]

This should make running the tests more pleasant. :)

[bkonyi, 2017-08-01 02:16:31]

LGTM for the most part. Any reason the precompiled configurations aren't
included yet?

https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
File tools/migration/bin/run_tests.dart (right):

https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
tools/migration/bin/run_tests.dart:47: //  "vm-precomp": [precompiler,
precompiled],
What's the issue here exactly? Those should be the right flags.

https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
tools/migration/bin/run_tests.dart:50: // dart2js-jsshell?
It might be useful to have these, but probably not that important right now.

https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
tools/migration/bin/run_tests.dart:54: // TODO(rnystrom): Is it worth running
dart2js on Firefox too?
There are some tests that I've run into that only fail on Firefox, so I don't
think it would hurt to add.

[Bob Nystrom, 2017-08-01 20:52:25]

Description was changed from

==========
Add a script to run the tests in a migration block.
==========

to

==========
Add a script to run the tests in a migration block.

R=bkonyi@google.com

Committed:
https://github.com/dart-lang/sdk/commit/95693b30a33a3882e1ab7fd89551eaccdab44329
==========

[Bob Nystrom, 2017-08-01 20:52:26]

Committed patchset #2 (id:20001) manually as
95693b30a33a3882e1ab7fd89551eaccdab44329 (presubmit successful).

[Bob Nystrom, 2017-08-01 20:52:41]

Thanks!

https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
File tools/migration/bin/run_tests.dart (right):

https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
tools/migration/bin/run_tests.dart:47: //  "vm-precomp": [precompiler,
precompiled],
On 2017/08/01 02:16:30, bkonyi wrote:
> What's the issue here exactly? Those should be the right flags.

I was getting some "snapshot version mismatch" when I tried that config and I
couldn't figure out which target in build.py to run to get things fixed, so I
commented it out for now. If you know how to fix that, I'd be happy to take a
patch to re-enable this.

https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
tools/migration/bin/run_tests.dart:50: // dart2js-jsshell?
On 2017/08/01 02:16:30, bkonyi wrote:
> It might be useful to have these, but probably not that important right now.

Acknowledged.

https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
tools/migration/bin/run_tests.dart:54: // TODO(rnystrom): Is it worth running
dart2js on Firefox too?
On 2017/08/01 02:16:30, bkonyi wrote:
> There are some tests that I've run into that only fail on Firefox, so I don't
> think it would hurt to add.

Did copying over the existing status entries cover that case? I'm OK with adding
Firefox if it's useful, but every config we add takes time so I want to focus on
the ones that deliver the most value.

[bkonyi, 2017-08-01 21:09:03]

On 2017/08/01 at 20:52:41, rnystrom wrote:
> Thanks!
> 
>
https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
> File tools/migration/bin/run_tests.dart (right):
> 
>
https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
> tools/migration/bin/run_tests.dart:47: //  "vm-precomp": [precompiler,
precompiled],
> On 2017/08/01 02:16:30, bkonyi wrote:
> > What's the issue here exactly? Those should be the right flags.
> 
> I was getting some "snapshot version mismatch" when I tried that config and I
couldn't figure out which target in build.py to run to get things fixed, so I
commented it out for now. If you know how to fix that, I'd be happy to take a
patch to re-enable this.
> 

I'll fiddle around with it and see if I can get it working :)

> 
>
https://codereview.chromium.org/2987223002/diff/1/tools/migration/bin/run_tes...
> tools/migration/bin/run_tests.dart:54: // TODO(rnystrom): Is it worth running
dart2js on Firefox too?
> On 2017/08/01 02:16:30, bkonyi wrote:
> > There are some tests that I've run into that only fail on Firefox, so I
don't
> > think it would hurt to add.
> 
> Did copying over the existing status entries cover that case? I'm OK with
adding Firefox if it's useful, but every config we add takes time so I want to
focus on the ones that deliver the most value.

I'm pretty sure just copying the existing status entries covered it. Let's just
leave it out for now and revisit this if we have issues with Firefox.