Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2987213002: [vm] Add Dart_CreateVMAOTSnapshotAsAssembly. (Closed)

Created:
3 years, 4 months ago by rmacnak
Modified:
3 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M runtime/include/dart_api.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
rmacnak
3 years, 4 months ago (2017-08-01 22:45:10 UTC) #4
siva
lgtm https://codereview.chromium.org/2987213002/diff/20001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/2987213002/diff/20001/runtime/vm/dart_api_impl.cc#newcode6589 runtime/vm/dart_api_impl.cc:6589: ApiReallocate, &image_writer, &image_writer); The second &image_write parameter can ...
3 years, 4 months ago (2017-08-01 22:55:39 UTC) #5
rmacnak
https://codereview.chromium.org/2987213002/diff/20001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/2987213002/diff/20001/runtime/vm/dart_api_impl.cc#newcode6589 runtime/vm/dart_api_impl.cc:6589: ApiReallocate, &image_writer, &image_writer); On 2017/08/01 22:55:38, siva wrote: > ...
3 years, 4 months ago (2017-08-02 00:55:40 UTC) #6
rmacnak
3 years, 4 months ago (2017-08-02 18:00:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
7f0204068d28c6f4c2e6799628e729165e290de4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698