Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2987203002: Migrated test block 17 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 17 to Dart 2.0. Fairly minor changes to print_test, and num_clamp_test was split into two tests to isolate compile time errors. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/8b36c83a106dea62f3425aa2fa797ef6125f8a4a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed tests that are no longer useful for Dart 2.0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3084 lines) Patch
M tests/corelib/corelib.status View 6 chunks +0 lines, -26 lines 0 comments Download
D tests/corelib/map_to_string_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/corelib/map_values2_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/corelib/map_values3_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/corelib/map_values4_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/corelib/map_values_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/corelib/maps_test.dart View 1 chunk +0 lines, -138 lines 0 comments Download
D tests/corelib/nan_infinity_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D tests/corelib/null_nosuchmethod_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/corelib/null_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/corelib/num_clamp_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D tests/corelib/num_parse_test.dart View 1 chunk +0 lines, -234 lines 0 comments Download
D tests/corelib/num_sign_test.dart View 1 chunk +0 lines, -109 lines 0 comments Download
D tests/corelib/print_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/corelib/queue_first_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/corelib/queue_iterator_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/corelib/queue_last_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/corelib/queue_single_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib/queue_test.dart View 1 chunk +0 lines, -488 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 1 6 chunks +29 lines, -0 lines 0 comments Download
A + tests/corelib_2/map_to_string_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_values2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_values3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_values4_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/map_values_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/maps_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/nan_infinity_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/null_nosuchmethod_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/null_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/num_clamp_test.dart View 3 chunks +0 lines, -12 lines 0 comments Download
A + tests/corelib_2/num_parse_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/num_sign_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/queue_first_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/queue_iterator_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/queue_last_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/queue_single_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/queue_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/corelib_strong/corelib_strong.status View 2 chunks +0 lines, -6 lines 0 comments Download
D tests/corelib_strong/map_to_string_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/corelib_strong/map_values2_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/corelib_strong/map_values3_test.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/corelib_strong/map_values4_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/corelib_strong/map_values_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/corelib_strong/maps_test.dart View 1 chunk +0 lines, -138 lines 0 comments Download
D tests/corelib_strong/nan_infinity_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D tests/corelib_strong/null_nosuchmethod_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/corelib_strong/null_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/corelib_strong/num_clamp_test.dart View 1 chunk +0 lines, -80 lines 0 comments Download
D tests/corelib_strong/num_parse_test.dart View 1 chunk +0 lines, -234 lines 0 comments Download
D tests/corelib_strong/num_sign_test.dart View 1 chunk +0 lines, -109 lines 0 comments Download
D tests/corelib_strong/print_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/corelib_strong/queue_first_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/corelib_strong/queue_iterator_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/corelib_strong/queue_last_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
D tests/corelib_strong/queue_single_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D tests/corelib_strong/queue_test.dart View 1 chunk +0 lines, -488 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 4 months ago (2017-07-31 21:04:42 UTC) #2
Bob Nystrom
Two tests to remove (and their status entries), then LGTM. https://codereview.chromium.org/2987203002/diff/1/tests/corelib_2/num_clamp_static_test.dart File tests/corelib_2/num_clamp_static_test.dart (right): https://codereview.chromium.org/2987203002/diff/1/tests/corelib_2/num_clamp_static_test.dart#newcode4 ...
3 years, 4 months ago (2017-07-31 21:26:40 UTC) #3
bkonyi
3 years, 4 months ago (2017-07-31 22:04:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8b36c83a106dea62f3425aa2fa797ef6125f8a4a.

Powered by Google App Engine
This is Rietveld 408576698