[vm] Revise Dart_IntegerToHexCString to avoid dependency on Bigint

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_OBJECT_H_
 #define RUNTIME_VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 6443 matching lines @@
   virtual uint32_t AsTruncatedUint32Value() const;
 
   virtual bool FitsIntoSmi() const;
 
   // Returns 0, -1 or 1.
   virtual int CompareWith(const Integer& other) const;
 
   // Return the most compact presentation of an integer.
   RawInteger* AsValidInteger() const;
 
+  // Converts integer to hex string.
+  virtual const char* ToHexCString(Zone* zone) const;

[siva, 2017/07/31 22:03:51]

Club this with virtual methods listed above.

Also please add a Note that when the Bigint class this decoupled from Integer
this method can become a regular method (de-virtualized).

[alexmarkov, 2017/08/01 15:42:28]

Done.

+
   // Returns null to indicate that a bigint operation is required.
   RawInteger* ArithmeticOp(Token::Kind operation,
                            const Integer& other,
                            Heap::Space space = Heap::kNew) const;
   RawInteger* BitOp(Token::Kind operation,
                     const Integer& other,
                     Heap::Space space = Heap::kNew) const;
 
  private:
   OBJECT_IMPLEMENTATION(Integer, Number);
@@ skipping 162 matching lines @@
   RawBool* neg() const { return raw_ptr()->neg_; }
   RawSmi* used() const { return raw_ptr()->used_; }
   RawTypedData* digits() const { return raw_ptr()->digits_; }
 
   // Accessors used by runtime calls from C++.
   bool Neg() const;
   intptr_t Used() const;
   uint32_t DigitAt(intptr_t index) const;
 
   const char* ToDecCString(Zone* zone) const;
-  const char* ToHexCString(Zone* zone) const;
+  virtual const char* ToHexCString(Zone* zone) const;

[siva, 2017/07/31 22:03:51]

Club this with all virtual methods declared above.

[alexmarkov, 2017/08/01 15:42:28]

Done.

 
   static const intptr_t kBitsPerDigit = 32;  // Same as _Bigint._DIGIT_BITS
   static const intptr_t kBytesPerDigit = 4;
   static const int64_t kDigitBase = 1LL << kBitsPerDigit;
   static const int64_t kDigitMask = kDigitBase - 1;
 
   static RawBigint* New(Heap::Space space = Heap::kNew);  // For snapshots.
 
   static RawBigint* New(bool neg,
                         intptr_t used,
@@ skipping 2328 matching lines @@
 
 inline void TypeArguments::SetHash(intptr_t value) const {
   // This is only safe because we create a new Smi, which does not cause
   // heap allocation.
   StoreSmi(&raw_ptr()->hash_, Smi::New(value));
 }
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_OBJECT_H_