Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: runtime/vm/kernel_binary_flowgraph.cc

Issue 2987143002: Fix parsing of ClosureCreation kernel nodes in VM. (Closed)
Patch Set: Cosmetic fixes. Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/test/closures/closures.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/kernel_binary_flowgraph.cc
diff --git a/runtime/vm/kernel_binary_flowgraph.cc b/runtime/vm/kernel_binary_flowgraph.cc
index 21311b2c2f6bf959a4d975cca8175f2261b50ae0..e2a800c306eaab3f282fbaa717a1e12f8e821dd5 100644
--- a/runtime/vm/kernel_binary_flowgraph.cc
+++ b/runtime/vm/kernel_binary_flowgraph.cc
@@ -696,7 +696,8 @@ void StreamingScopeBuilder::VisitExpression() {
case kClosureCreation:
builder_->SkipCanonicalNameReference(); // read function reference.
VisitExpression(); // read context vector.
- VisitDartType(); // read function type of the closure.
+ VisitDartType(); // read function type of the closure.
+ builder_->SkipListOfDartTypes(); // read type arguments.
return;
default:
UNREACHABLE();
@@ -4013,6 +4014,7 @@ void StreamingFlowGraphBuilder::SkipExpression() {
SkipCanonicalNameReference(); // read top-level function reference.
SkipExpression(); // read context vector.
SkipDartType(); // read function type.
+ SkipListOfDartTypes(); // read type arguments.
return;
case kBigIntLiteral:
SkipStringReference(); // read string reference.
@@ -5914,6 +5916,7 @@ Fragment StreamingFlowGraphBuilder::BuildClosureCreation(
instructions += Drop();
SkipDartType(); // skip function type of the closure.
+ SkipListOfDartTypes(); // skip list of type arguments.
return instructions;
}
« no previous file with comments | « pkg/kernel/test/closures/closures.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698